You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cclauss <gi...@git.apache.org> on 2018/08/29 09:47:33 UTC
[GitHub] spark pull request #22266: lint-python: Add flake8 tests to find Python synt...
GitHub user cclauss opened a pull request:
https://github.com/apache/spark/pull/22266
lint-python: Add flake8 tests to find Python syntax errors and undefi…
…ned names
Add [flake8](http://flake8.pycqa.org) tests to find Python syntax errors and undefined names.
__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
## What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cclauss/spark patch-3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22266.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22266
----
commit 129119803eacbca1a53384893424e4ae75774626
Author: cclauss <cc...@...>
Date: 2018-08-29T09:46:38Z
lint-python: Add flake8 tests to find Python syntax errors and undefined names
Add [flake8](http://flake8.pycqa.org) tests to find Python syntax errors and undefined names.
__E901,E999,F821,F822,F823__ are the "_showstopper_" flake8 issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
* E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95501 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95501/testReport)** for PR 22266 at commit [`c8c0543`](https://github.com/apache/spark/commit/c8c05431c451307b2a55edc6ad3ae3f7569e356b).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95447 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95447/testReport)** for PR 22266 at commit [`1291198`](https://github.com/apache/spark/commit/129119803eacbca1a53384893424e4ae75774626).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214413523
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
+flake8_status="${PIPESTATUS[0]}"
+# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
--- End diff --
And to be clear, this one is just to output all of the errors/warnings not actually stop the build, thats the one above? I think this might get confusing to folks who have flake8 stop the build and then think they need to fix everything here. What do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: lint-python: Add flake8 to find syntax errors and undefi...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22266
These tests should fail until #22265 or similar is merged.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214196909
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
--- End diff --
Removed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95556 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95556/testReport)** for PR 22266 at commit [`786d0c9`](https://github.com/apache/spark/commit/786d0c9e730d04885d33da6d2b6cc098ee1dcf1e).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/22266
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95556 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95556/testReport)** for PR 22266 at commit [`786d0c9`](https://github.com/apache/spark/commit/786d0c9e730d04885d33da6d2b6cc098ee1dcf1e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22266
Merged to master, it's not in branch-2.4 (although if folks think in belongs there I'm open to that). I haven't closed the JIRA yet because we don't have the version tag in JIRA for the next release after 2.4.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95555/testReport)** for PR 22266 at commit [`b87c49e`](https://github.com/apache/spark/commit/b87c49e5e36105e392a81e0547b1002b336e6824).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22266
Oh wait that was fixed in master I just had this branch checked out. Verified flake8 cmd against f96a8bf8ffe9472a839ca482f64c7cdf7540c243 so we should be fine to merge to master without breaking anything. LGTM
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r213873372
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
--- End diff --
yea, I don't think you can do install like this on building server.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95447 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95447/testReport)** for PR 22266 at commit [`1291198`](https://github.com/apache/spark/commit/129119803eacbca1a53384893424e4ae75774626).
* This patch **fails Python style tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on the issue:
https://github.com/apache/spark/pull/22266
This LGTM but my only problem is we introduced another undefined name in the java_gateway in the meantime. I'll fix that today and merge this PR.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214413219
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
+flake8_status="${PIPESTATUS[0]}"
+# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
--- End diff --
From https://spark.apache.org/contributing.html our max line length should be 100
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214201610
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
--- End diff --
My take is that we want contributors to be able to locally detect syntax errors and undefined names _before_ they submit a pull request.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: lint-python: Add flake8 to find syntax errors and undefi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on the issue:
https://github.com/apache/spark/pull/22266
Can you also format the PR description to follow the template?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95556/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: lint-python: Add flake8 to find syntax errors and undefi...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22266
Can you file a JIRA please?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r213880767
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
--- End diff --
Yea, this is what the build manager should do cc @shaneknapp.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214117901
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
--- End diff --
flake8 is installed on all centos and ubuntu workers.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/22266
ok to test
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95555/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by holdenk <gi...@git.apache.org>.
Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214412844
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
--- End diff --
I think flake8 not being found is a pretty clear message you need to install flake8. If we list it in `dev/requirements.txt` maybe that would help folks?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by shaneknapp <gi...@git.apache.org>.
Github user shaneknapp commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214114395
--- Diff: dev/lint-python ---
@@ -82,6 +82,26 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+python -m pip install flake8
--- End diff --
yep. please remove this line, and i can ensure that it's installed on the workers.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95447/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214203205
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
--- End diff --
If so, maybe it's still good to detect `flake8` and show some message to ask for install.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/95501/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by cclauss <gi...@git.apache.org>.
Github user cclauss commented on the issue:
https://github.com/apache/spark/pull/22266
@HyukjinKwon Done.
@viirya Done.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214200375
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
--- End diff --
Are we asking this as required in local too? Or we shall skip this if it is not installed on local?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: lint-python: Add flake8 tests to find Python syntax erro...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95555/testReport)** for PR 22266 at commit [`b87c49e`](https://github.com/apache/spark/commit/b87c49e5e36105e392a81e0547b1002b336e6824).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: lint-python: Add flake8 to find syntax errors and undefi...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/22266
Can one of the admins verify this patch?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #22266: [SPARK-25270] lint-python: Add flake8 to find syn...
Posted by viirya <gi...@git.apache.org>.
Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/22266#discussion_r214494032
--- Diff: dev/lint-python ---
@@ -82,6 +82,25 @@ else
rm "$PYCODESTYLE_REPORT_PATH"
fi
+# stop the build if there are Python syntax errors or undefined names
+flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
--- End diff --
Yea, sounds good.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #22266: [SPARK-25270] lint-python: Add flake8 to find syntax err...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/22266
**[Test build #95501 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/95501/testReport)** for PR 22266 at commit [`c8c0543`](https://github.com/apache/spark/commit/c8c05431c451307b2a55edc6ad3ae3f7569e356b).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org