You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "oxsean (via GitHub)" <gi...@apache.org> on 2024/04/11 09:44:56 UTC
[I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]
oxsean opened a new issue, #14068:
URL: https://github.com/apache/dubbo/issues/14068
### Pre-check
- [X] I am sure that all the content I provide is in English.
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dubbo/issues?q=is%3Aissue) and found no similar feature requirement.
### Apache Dubbo Component
Java SDK (apache/dubbo)
### Descriptions
If the client provides a body input that is too large or the response output is too large, it could make server OOM. Therefore, it is necessary to limit their sizes to prevent DOS attacks.
### Related issues
_No response_
### Are you willing to submit a pull request to fix on your own?
- [X] Yes I am willing to submit a pull request on my own!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]
Posted by "oxsean (via GitHub)" <gi...@apache.org>.
oxsean closed issue #14068: [Feature][3.3] Triple http limiting the size of the HTTP request and response
URL: https://github.com/apache/dubbo/issues/14068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]
Posted by "finefuture (via GitHub)" <gi...@apache.org>.
finefuture commented on issue #14068:
URL: https://github.com/apache/dubbo/issues/14068#issuecomment-2049323257
I'm working on it, please assign it to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]
Posted by "Chenjp (via GitHub)" <gi...@apache.org>.
Chenjp commented on issue #14068:
URL: https://github.com/apache/dubbo/issues/14068#issuecomment-2138768650
@finefuture
Pls consider adding support for following scope level "max-body-size":
1. Application;
2. Protocol;
3. Service;
Priority : Service>Protocol>Application.
Example:
1. Nginx:
```
Syntax: client_max_body_size size;
Context: http, server, location
```
2. Another Example: [Kong request-size-limiting](https://docs.konghq.com/hub/kong-inc/request-size-limiting/configuration/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [I] [Feature][3.3] Triple http limiting the size of the HTTP request and response [dubbo]
Posted by "finefuture (via GitHub)" <gi...@apache.org>.
finefuture commented on issue #14068:
URL: https://github.com/apache/dubbo/issues/14068#issuecomment-2139428093
> @finefuture
>
> Pls consider adding support for following scope level "max-body-size":
>
> 1. Application;
> 2. Protocol;
> 3. Service;
>
> Priority : Service>Protocol>Application.
>
> Example:
>
> 1. Nginx:
>
> ```
> Syntax: client_max_body_size size;
> Context: http, server, location
> ```
>
> 2. Another Example: [Kong request-size-limiting](https://docs.konghq.com/hub/kong-inc/request-size-limiting/configuration/)
Good idea, but cross-protocol may involve relatively large changes. Maybe we can implement it in triple protocol first. We need to discuss this feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org