You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2017/12/15 20:55:56 UTC
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8854
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
This patch fixes several issues related to the min/max aggregate
functions and their handling of 'nan' and 'inf':
- Previously, if 'inf' or '-inf' was the only value for the min/max
and codegen was being used, the result would be incorrect. This
occurred, for example in the case of 'inf' and 'min', because we
set an initial value of numeric_limits::max, which is less than
'inf', so the returned min was numeric_limits::max when it should be
'inf'. The fix is to set the initial value to
numeric_limits::infinity.
- Previously, if one of the values was 'nan', the result of min/max
was non-deterministic depending on the order the values were
evaluated in. This occurs because 'nan' < or > 'any value' is always
false, so if the first value added was 'nan', all other comparisons
would be false and 'nan' would be returned, whereas if the first
value wasn't 'nan' then the 'nan' wouldn't be returned. The fix is
to treat 'nan' specially and to always return 'nan' if there is a
single 'nan' value.
Testing:
- Added e2e tests for both scenarios.
Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-value.h
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
6 files changed, 72 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/8854/1
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 04 Jan 2018 01:23:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1671/
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2018 21:49:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Hello Michael Ho, Tim Armstrong, Bikramjeet Vig,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8854
to look at the new patch set (#3).
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
This patch fixes several issues related to the min/max aggregate
functions and their handling of 'nan' and 'inf':
- Previously, if 'inf' or '-inf' was the only value for the min/max
and codegen was being used, the result would be incorrect. This
occurred, for example in the case of 'inf' and 'min', because we
set an initial value of numeric_limits::max, which is less than
'inf', so the returned min was numeric_limits::max when it should be
'inf'. The fix is to set the initial value to
numeric_limits::infinity.
- Previously, if one of the values was 'nan', the result of min/max
was non-deterministic depending on the order the values were
evaluated in. This occurs because 'nan' < or > 'any value' is always
false, so if the first value added was 'nan', all other comparisons
would be false and 'nan' would be returned, whereas if the first
value wasn't 'nan' then the 'nan' wouldn't be returned. The fix is
to treat 'nan' specially and to always return 'nan' if there is a
single 'nan' value.
Testing:
- Added e2e tests for both scenarios, as well as adding a little extra
nan/inf coverage for other aggregate functions.
Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-value.h
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
6 files changed, 97 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/8854/3
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc@611
PS4, Line 611: src.val != src.val
> In light of IMPALA-6527 I revisited this code. Is it possible for the compi
I would certainly hope there aren't any compilers that would optimize this away, since doing so would change the behavior of the program, but I'm not sure.
The note on that page seems to indicate that this is a valid way of testing for nan, and we have tests that should (hopefully) catch it if it turns out not to be.
I don't see any harm in making the change, though, if you're worried about it.
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Feb 2018 23:57:59 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
This patch fixes several issues related to the min/max aggregate
functions and their handling of 'nan' and 'inf':
- Previously, if 'inf' or '-inf' was the only value for the min/max
and codegen was being used, the result would be incorrect. This
occurred, for example in the case of 'inf' and 'min', because we
set an initial value of numeric_limits::max, which is less than
'inf', so the returned min was numeric_limits::max when it should be
'inf'. The fix is to set the initial value to
numeric_limits::infinity.
- Previously, if one of the values was 'nan', the result of min/max
was non-deterministic depending on the order the values were
evaluated in. This occurs because 'nan' < or > 'any value' is always
false, so if the first value added was 'nan', all other comparisons
would be false and 'nan' would be returned, whereas if the first
value wasn't 'nan' then the 'nan' wouldn't be returned. The fix is
to treat 'nan' specially and to always return 'nan' if there is a
single 'nan' value.
Testing:
- Added e2e tests for both scenarios.
Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-value.h
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
6 files changed, 76 insertions(+), 35 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/54/8854/2
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2018 17:21:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 2:
(2 comments)
looks pretty solid to me
http://gerrit.cloudera.org:8080/#/c/8854/2/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:
http://gerrit.cloudera.org:8080/#/c/8854/2/be/src/codegen/llvm-codegen.h@497
PS2, Line 497: /// Codegen comparing 'src' and the value in 'dst_slot_ptr' and store 'src' in
: /// 'dst_slot_ptr' if it is less than/greater than (depending on 'min').
nit, how about:
Codegen at the current builder location in function 'fn' to store the max/min('src', value in 'dst_slot_ptr') in 'dst_slot_ptr'
http://gerrit.cloudera.org:8080/#/c/8854/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test
File testdata/workloads/functional-query/queries/QueryTest/aggregation.test:
http://gerrit.cloudera.org:8080/#/c/8854/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@1345
PS2, Line 1345: values (0), (1), (cast('nan' as double)
maybe include inf/-inf
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Dec 2017 22:46:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
This patch fixes several issues related to the min/max aggregate
functions and their handling of 'nan' and 'inf':
- Previously, if 'inf' or '-inf' was the only value for the min/max
and codegen was being used, the result would be incorrect. This
occurred, for example in the case of 'inf' and 'min', because we
set an initial value of numeric_limits::max, which is less than
'inf', so the returned min was numeric_limits::max when it should be
'inf'. The fix is to set the initial value to
numeric_limits::infinity.
- Previously, if one of the values was 'nan', the result of min/max
was non-deterministic depending on the order the values were
evaluated in. This occurs because 'nan' < or > 'any value' is always
false, so if the first value added was 'nan', all other comparisons
would be false and 'nan' would be returned, whereas if the first
value wasn't 'nan' then the 'nan' wouldn't be returned. The fix is
to treat 'nan' specially and to always return 'nan' if there is a
single 'nan' value.
Testing:
- Added e2e tests for both scenarios, as well as adding a little extra
nan/inf coverage for other aggregate functions.
Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Reviewed-on: http://gerrit.cloudera.org:8080/8854
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M be/src/codegen/llvm-codegen.cc
M be/src/codegen/llvm-codegen.h
M be/src/exec/partitioned-aggregation-node.cc
M be/src/exprs/aggregate-functions-ir.cc
M be/src/exprs/expr-value.h
M testdata/workloads/functional-query/queries/QueryTest/aggregation.test
6 files changed, 97 insertions(+), 35 deletions(-)
Approvals:
Bikramjeet Vig: Looks good to me, but someone else must approve
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 23:03:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/8854/2/be/src/codegen/llvm-codegen.h
File be/src/codegen/llvm-codegen.h:
http://gerrit.cloudera.org:8080/#/c/8854/2/be/src/codegen/llvm-codegen.h@497
PS2, Line 497: /// Codegen at the current builder location in function 'fn' to store the
: /// max/min('src', value in 'dst_slot_ptr') in 'dst_slot_ptr'
> nit, how about:
Done
http://gerrit.cloudera.org:8080/#/c/8854/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test
File testdata/workloads/functional-query/queries/QueryTest/aggregation.test:
http://gerrit.cloudera.org:8080/#/c/8854/2/testdata/workloads/functional-query/queries/QueryTest/aggregation.test@1345
PS2, Line 1345: values (0), (1), (cast('nan' as double)
> maybe include inf/-inf
Done
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Dec 2017 22:40:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8854 )
Change subject: IMPALA-6295: Fix mix/max handling of 'nan' and 'inf'
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc
File be/src/exprs/aggregate-functions-ir.cc:
http://gerrit.cloudera.org:8080/#/c/8854/4/be/src/exprs/aggregate-functions-ir.cc@611
PS4, Line 611: src.val != src.val
In light of IMPALA-6527 I revisited this code. Is it possible for the compiler to optimize this check away? Should we use std::isnan() instead?
http://en.cppreference.com/w/cpp/numeric/math/isnan
--
To view, visit http://gerrit.cloudera.org:8080/8854
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1e206105937ce5afc75ca5044597d39b3dc6a81
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 4
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Michael Ho <kw...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Feb 2018 17:09:14 +0000
Gerrit-HasComments: Yes