You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2026/03/03 13:44:52 UTC
svn commit: r1932134 - pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption
Author: tilman
Date: Tue Mar 3 13:44:52 2026
New Revision: 1932134
Log:
PDFBOX-5660: optimize, as suggested by Valery Bokov; closes #423
Modified:
pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java
Modified: pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java
==============================================================================
--- pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java Tue Mar 3 13:43:58 2026 (r1932133)
+++ pdfbox/branches/2.0/pdfbox/src/main/java/org/apache/pdfbox/pdmodel/encryption/PublicKeySecurityHandler.java Tue Mar 3 13:44:52 2026 (r1932134)
@@ -250,7 +250,8 @@ public final class PublicKeySecurityHand
}
byte[] mdResult;
- if (encryption.getVersion() == 4 || encryption.getVersion() == 5)
+ int encryptionVersion = encryption.getVersion();
+ if (encryptionVersion == 4 || encryptionVersion == 5)
{
if (!isDecryptMetadata())
{
@@ -259,7 +260,7 @@ public final class PublicKeySecurityHand
sha1Input = Arrays.copyOf(sha1Input, sha1Input.length + 4);
System.arraycopy(new byte[]{ (byte) 0xff, (byte) 0xff, (byte) 0xff, (byte) 0xff}, 0, sha1Input, sha1Input.length - 4, 4);
}
- if (encryption.getVersion() == 4)
+ if (encryptionVersion == 4)
{
mdResult = MessageDigests.getSHA1().digest(sha1Input);
}