You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/07/29 21:57:41 UTC

Review Request 71187: Updated PushGauge to work with double.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71187/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Meng Zhu.


Bugs: MESOS-9861
    https://issues.apache.org/jira/browse/MESOS-9861


Repository: mesos


Description
-------

This enables adoption in Mesos code, since many PullGauges are
set with double values.


Diffs
-----

  3rdparty/libprocess/include/process/metrics/push_gauge.hpp 0dd2c205bdb2294c30efeb2ea7d5f9cb4bebe307 


Diff: https://reviews.apache.org/r/71187/diff/1/


Testing
-------

make check


Thanks,

Benjamin Mahler

Re: Review Request 71187: Updated PushGauge to work with double.

Posted by Meng Zhu <mz...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71187/#review216927
-----------------------------------------------------------


Ship it!




Ship It!

- Meng Zhu


On July 29, 2019, 2:57 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71187/
> -----------------------------------------------------------
> 
> (Updated July 29, 2019, 2:57 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Meng Zhu.
> 
> 
> Bugs: MESOS-9861
>     https://issues.apache.org/jira/browse/MESOS-9861
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This enables adoption in Mesos code, since many PullGauges are
> set with double values.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/metrics/push_gauge.hpp 0dd2c205bdb2294c30efeb2ea7d5f9cb4bebe307 
> 
> 
> Diff: https://reviews.apache.org/r/71187/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>