[GitHub] [rocketmq] aaron-ai commented on a diff in pull request #5245: [ISSUE #4658] remove redundant logic

[GitBox <gi...@apache.org>]

aaron-ai commented on code in PR #5245:
URL: https://github.com/apache/rocketmq/pull/5245#discussion_r990581116


##########
client/src/main/java/org/apache/rocketmq/client/impl/producer/DefaultMQProducerImpl.java:
##########
@@ -348,11 +348,9 @@ public void run() {
                     try {
                         if (transactionCheckListener != null) {
                             localTransactionState = transactionCheckListener.checkLocalTransactionState(message);
-                        } else if (transactionListener != null) {
+                        } else {
                             log.debug("Used new check API in transaction message");

Review Comment:
   ```suggestion
                               log.warn("transactionListener is null, producerGroup={}", group);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org