[jira] [Commented] (HIVE-2663) DynamicSerDeTypeList.serialize() method have null check for the "nullProtocol" it needs to be change.

["Chinna Rao Lalam (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174831#comment-13174831 ] 

Chinna Rao Lalam commented on HIVE-2663:
----------------------------------------

In the below case nulll check is not needed and this will make the code complicated and looks bugy like 

if (element == null && nullProtocol != null) {

here if element = null and nullProtocol = null the else block will be executed with element = null.

So we can remove the check nullProtocol != null.
                
> DynamicSerDeTypeList.serialize() method  have null check for the "nullProtocol" it needs to be change.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2663
>                 URL: https://issues.apache.org/jira/browse/HIVE-2663
>             Project: Hive
>          Issue Type: Bug
>          Components: Serializers/Deserializers
>         Environment: Hadoop 0.20.1, Hive0.9.0 and SUSE Linux Enterprise Server 10 SP2 (i586) - Kernel 2.6.16.60-0.21-smp (5).
>            Reporter: Chinna Rao Lalam
>            Assignee: Chinna Rao Lalam
>            Priority: Minor
>         Attachments: HIVE-2663.patch
>
>
> In DynamicSerDeTypeList.serialize() method have the null check for the "nullProtocol" like
>  if (element == null && nullProtocol != null) {
> here if element= null and nullProtocol=null in this case it will execute else block with element=null.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira