You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/04/17 03:13:33 UTC

Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Added 1.8.0 allocator performance improvements to the CHANGELOG.


Diffs
-----

  CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 


Diff: https://reviews.apache.org/r/70492/diff/1/


Testing
-------

N/A


Thanks,

Meng Zhu


Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

Posted by Meng Zhu <mz...@mesosphere.io>.

> On April 16, 2019, 8:22 p.m., Benjamin Mahler wrote:
> > Do we have a range of percentages we see from benchmarks that we can make to give users a better sense of how much?

Added some numbers.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214713
-----------------------------------------------------------


On April 16, 2019, 8:38 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> -----------------------------------------------------------
> 
> (Updated April 16, 2019, 8:38 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/2/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214713
-----------------------------------------------------------



Do we have a range of percentages we see from benchmarks that we can make to give users a better sense of how much?

- Benjamin Mahler


On April 17, 2019, 3:13 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> -----------------------------------------------------------
> 
> (Updated April 17, 2019, 3:13 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/1/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214717
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['70492']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3190/mesos-review-70492

Relevant logs:

- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/3190/mesos-review-70492/logs/mesos-tests.log):

```
I0417 04:56:14.028235 64360 master.cpp:3333] Disconnecting agent 9da5b5de-272d-40f9-9b41-2f95ec052867-S0 at slave(501)@192.10.1.4:60109 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0417 04:56:14.029237 64360 master.cpp:3352] Deactivating agent 9da5b5de-272d-40f9-9b41-2f95ec052867-S0 at slave(501)@192.10.1.4:60109 (windows-01.chtsmhjxogyevckjfayqqcnjda.xx.internal.cloudapp.net)
I0417 04:56:14.029237 59068 hierarchical.cpp:392] Removed framework 9da5b5de-272d-40f9-9b41-2f95ec052867-0000
I0417 04:56:14.030264 59068 hierarchical.cpp:829] Agent 9da5b5de-272d-40f9-9b41-2f95ec052867-S0 deactivated
I0417 04:56:14.030264 66484 containerizer.cpp:2576] Destroying container f8533bd4-0ecb-4157-9e50-f1f1f44f63e3 in RUNNING state
I0417 04:56:14.031244 66484 containerizer.cpp:3278] Transitioning the state of container f8533bd4-0ecb-4157-9e50-f1f1f44f63e3 from RUNNING to DESTROYING
I0417 04:56:14.031244 66484 launcher.cpp:161] Asked to destroy container f8533bd4-0ecb-4157-9e50-f1f1f44f63e3
W0417 04:56:14.032260 66344 process.cpp:1423] Failed to recv on socket WindowsFD::Type::SOCKET=5420 to peer '192.10.1.4:62508': IO failed with error code: The specified network name is no longer available.

W0417 04:56:14.033593 66344 process.cpp:838] Failed to recv on socket WindowsFD::Type::SOCKET=5568 to peer '192.10.1.4:62509': IO failed with error code: The specified network name is no longer available.

I0417 04:56:14.080252 66308 containerizer.cpp:3117] [       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (865 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (883 ms total)

[----------] Global test environment tear-down
[==========] 1161 tests from 109 test cases ran. (587899 ms total)
[  PASSED  ] 1158 tests.
[  FAILED  ] 3 tests, listed below:
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchManifest
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_FetchImage
[  FAILED  ] DockerFetcherPluginTest.INTERNET_CURL_InvokeFetchByName

 3 FAILED TESTS
  YOU HAVE 233 DISABLED TESTS

Container f8533bd4-0ecb-4157-9e50-f1f1f44f63e3 has exited
I0417 04:56:14.110242 66104 master.cpp:1135] Master terminating
I0417 04:56:14.112241 59068 hierarchical.cpp:680] Removed agent 9da5b5de-272d-40f9-9b41-2f95ec052867-S0
I0417 04:56:14.947244 66344 process.cpp:927] Stopped the socket accept loop
```

- Mesos Reviewbot Windows


On April 17, 2019, 3:38 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> -----------------------------------------------------------
> 
> (Updated April 17, 2019, 3:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/2/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/#review214716
-----------------------------------------------------------



Patch looks great!

Reviews applied: [70492]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 17, 2019, 3:38 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70492/
> -----------------------------------------------------------
> 
> (Updated April 17, 2019, 3:38 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 1.8.0 allocator performance improvements to the CHANGELOG.
> 
> 
> Diffs
> -----
> 
>   CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 
> 
> 
> Diff: https://reviews.apache.org/r/70492/diff/2/
> 
> 
> Testing
> -------
> 
> N/A
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Re: Review Request 70492: Added 1.8.0 allocator performance improvements to the CHANGELOG.

Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70492/
-----------------------------------------------------------

(Updated April 16, 2019, 8:38 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Added 1.8.0 allocator performance improvements to the CHANGELOG.


Diffs (updated)
-----

  CHANGELOG c4941b256aee146fb06e1ace2551547435b179dc 


Diff: https://reviews.apache.org/r/70492/diff/2/

Changes: https://reviews.apache.org/r/70492/diff/1-2/


Testing
-------

N/A


Thanks,

Meng Zhu