You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Nate Cole <nc...@hortonworks.com> on 2014/04/11 19:39:42 UTC

Review Request 20265: Flume: process reporting mechanism

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20265/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk and Dmytro Sen.


Bugs: AMBARI-5441
    https://issues.apache.org/jira/browse/AMBARI-5441


Repository: ambari


Description
-------

* Add to the flume classes, as structuredOut, process information.  This will be consumed by Ambari in a later patch.
* Miscellaneous fixes to recording PID, checking process status, etc


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 551b59e 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 91d1b8d 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 3b175a1 
  ambari-agent/src/main/python/resource_management/libraries/script/script.py d62bcd1 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py abc6edc 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 54c17a6 
  ambari-agent/src/test/python/ambari_agent/TestPuppetExecutor.py eb9cf45 
  ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py 8a73410 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py a24ad4a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 341379d 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 48920e1 

Diff: https://reviews.apache.org/r/20265/diff/


Testing
-------

ambari-server:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:39.042s
[INFO] Finished at: Fri Apr 11 13:33:02 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------

ambari-agent
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 407 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.460s
[INFO] Finished at: Fri Apr 11 13:10:58 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole


Re: Review Request 20265: Flume: process reporting mechanism

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20265/#review40271
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On April 14, 2014, 1:33 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20265/
> -----------------------------------------------------------
> 
> (Updated April 14, 2014, 1:33 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-5441
>     https://issues.apache.org/jira/browse/AMBARI-5441
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> * Add to the flume classes, as structuredOut, process information.  This will be consumed by Ambari in a later patch.
> * Miscellaneous fixes to recording PID, checking process status, etc
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 551b59e 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 91d1b8d 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 3b175a1 
>   ambari-agent/src/main/python/resource_management/libraries/script/script.py d62bcd1 
>   ambari-agent/src/test/python/ambari_agent/TestActionQueue.py abc6edc 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 54c17a6 
>   ambari-agent/src/test/python/ambari_agent/TestPuppetExecutor.py eb9cf45 
>   ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py 8a73410 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py a24ad4a 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 341379d 
>   ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 48920e1 
> 
> Diff: https://reviews.apache.org/r/20265/diff/
> 
> 
> Testing
> -------
> 
> ambari-server:
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 14:39.042s
> [INFO] Finished at: Fri Apr 11 13:33:02 EDT 2014
> [INFO] Final Memory: 20M/123M
> [INFO] ------------------------------------------------------------------------
> 
> ambari-agent
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 407 licence.
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 11.460s
> [INFO] Finished at: Fri Apr 11 13:10:58 EDT 2014
> [INFO] Final Memory: 7M/81M
> [INFO] ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nate Cole
> 
>


Re: Review Request 20265: Flume: process reporting mechanism

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20265/
-----------------------------------------------------------

(Updated April 14, 2014, 9:33 a.m.)


Review request for Ambari, Andrew Onischuk, Dmytro Sen, and Sumit Mohanty.


Changes
-------

Added a reviewer.


Bugs: AMBARI-5441
    https://issues.apache.org/jira/browse/AMBARI-5441


Repository: ambari


Description
-------

* Add to the flume classes, as structuredOut, process information.  This will be consumed by Ambari in a later patch.
* Miscellaneous fixes to recording PID, checking process status, etc


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 551b59e 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 91d1b8d 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 3b175a1 
  ambari-agent/src/main/python/resource_management/libraries/script/script.py d62bcd1 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py abc6edc 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 54c17a6 
  ambari-agent/src/test/python/ambari_agent/TestPuppetExecutor.py eb9cf45 
  ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py 8a73410 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume.py a24ad4a 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/FLUME/package/scripts/flume_handler.py 341379d 
  ambari-server/src/test/python/stacks/2.0.6/FLUME/test_flume.py 48920e1 

Diff: https://reviews.apache.org/r/20265/diff/


Testing
-------

ambari-server:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 14:39.042s
[INFO] Finished at: Fri Apr 11 13:33:02 EDT 2014
[INFO] Final Memory: 20M/123M
[INFO] ------------------------------------------------------------------------

ambari-agent
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 approved: 407 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.460s
[INFO] Finished at: Fri Apr 11 13:10:58 EDT 2014
[INFO] Final Memory: 7M/81M
[INFO] ------------------------------------------------------------------------


Thanks,

Nate Cole