You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/03/19 17:58:58 UTC

[GitHub] [gobblin] vikrambohra opened a new pull request #3248: [GOBBLIN-571] Rename staging file name with record count before movin…

vikrambohra opened a new pull request #3248:
URL: https://github.com/apache/gobblin/pull/3248

…g to task output directory

Dear Gobblin maintainers,

Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!

### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-571] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-571

### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):

### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:

### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] vikrambohra closed pull request #3248: [GOBBLIN-571] Rename staging file name with record count before movin…

Posted by GitBox <gi...@apache.org>.

vikrambohra closed pull request #3248:
URL: https://github.com/apache/gobblin/pull/3248


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] vikrambohra commented on pull request #3248: [GOBBLIN-571] Rename staging file name with record count before movin…

Posted by GitBox <gi...@apache.org>.

vikrambohra commented on pull request #3248:
URL: https://github.com/apache/gobblin/pull/3248#issuecomment-804310457


   Duplicate of https://github.com/apache/gobblin/pull/3251


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] ZihanLi58 commented on a change in pull request #3248: [GOBBLIN-571] Rename staging file name with record count before movin…

Posted by GitBox <gi...@apache.org>.

ZihanLi58 commented on a change in pull request #3248:
URL: https://github.com/apache/gobblin/pull/3248#discussion_r598015437



##########
File path: gobblin-core/src/main/java/org/apache/gobblin/writer/FsDataWriter.java
##########
@@ -256,19 +256,19 @@ public void commit()
 
     this.bytesWritten = Optional.of(Long.valueOf(stagingFileStatus.getLen()));
 
+    // Rename staging file to add record count before copying to output file
+    if (this.shouldIncludeRecordCountInFileName) {
+      String filePathWithRecordCount = addRecordCountToStagingFile();
+      this.stagingFile = new Path(filePathWithRecordCount);
+      this.outputFile = new Path(this.outputFile.getParent().toString(), new Path(filePathWithRecordCount).getName());
+    }
+    this.properties.appendToSetProp(this.allOutputFilesPropName, this.outputFile.toString());

Review comment:
       should we move this line after we moving the staging file into output dir?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [gobblin] ZihanLi58 commented on pull request #3248: [GOBBLIN-571] Rename staging file name with record count before movin…

Posted by GitBox <gi...@apache.org>.

ZihanLi58 commented on pull request #3248:
URL: https://github.com/apache/gobblin/pull/3248#issuecomment-803179285


   Seems like it's linked to a wrong ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org