You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2019/09/05 16:14:57 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3113: STORM-3482 Implement One Worker Per Component Option

Ethanlm commented on a change in pull request #3113: STORM-3482 Implement One Worker Per Component Option
URL: https://github.com/apache/storm/pull/3113#discussion_r321357142
 
 

 ##########
 File path: storm-server/src/main/java/org/apache/storm/scheduler/resource/RasNode.java
 ##########
 @@ -362,15 +364,40 @@ public void assignSingleExecutor(WorkerSlot ws, ExecutorDetails exec, TopologyDe
      * @return true if it would fit else false
      */
     public boolean wouldFit(WorkerSlot ws, ExecutorDetails exec, TopologyDetails td) {
-        assert nodeId.equals(ws.getNodeId()) : "Slot " + ws + " is not a part of this node " + nodeId;
 
 Review comment:
   I didn't notice this before. Why do we want to delete this line

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services