You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mgubaidullin (via GitHub)" <gi...@apache.org> on 2023/02/15 15:34:45 UTC
[GitHub] [camel] mgubaidullin opened a new pull request, #9355: Implements CAMEL-19044
mgubaidullin opened a new pull request, #9355:
URL: https://github.com/apache/camel/pull/9355
Camel-Jbang catalog output in JSON
https://issues.apache.org/jira/browse/CAMEL-19044
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #9355: Implements CAMEL-19044
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #9355:
URL: https://github.com/apache/camel/pull/9355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mgubaidullin commented on pull request #9355: Implements CAMEL-19044
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on PR #9355:
URL: https://github.com/apache/camel/pull/9355#issuecomment-1431679050
I have executed `mvn clean install -Pfastinstall,format` and there are no changes in the code
Why else checkstyle might fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9355: Implements CAMEL-19044
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9355:
URL: https://github.com/apache/camel/pull/9355#issuecomment-1431677551
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #9355: Implements CAMEL-19044
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #9355:
URL: https://github.com/apache/camel/pull/9355#discussion_r1107309592
##########
dsl/camel-jbang/camel-jbang-core/src/main/java/org/apache/camel/dsl/jbang/core/commands/catalog/CatalogBaseCommand.java:
##########
@@ -19,11 +19,13 @@
import java.util.Arrays;
import java.util.List;
import java.util.Locale;
+import java.util.Map;
import java.util.stream.Collectors;
import com.github.freva.asciitable.AsciiTable;
import com.github.freva.asciitable.Column;
import com.github.freva.asciitable.HorizontalAlign;
+import io.vertx.core.json.Json;
Review Comment:
We should not use vertx for json.
Instead we have `camel-util-json` where we have Camel specific json library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] mgubaidullin commented on pull request #9355: Implements CAMEL-19044
Posted by "mgubaidullin (via GitHub)" <gi...@apache.org>.
mgubaidullin commented on PR #9355:
URL: https://github.com/apache/camel/pull/9355#issuecomment-1431568335
https://github.com/apache/camel/pull/9356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #9355: Implements CAMEL-19044
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #9355:
URL: https://github.com/apache/camel/pull/9355#issuecomment-1431632937
:no_entry_sign: There are (likely) no components to be tested in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org