You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "cuiziwei1 (via GitHub)" <gi...@apache.org> on 2024/10/18 13:52:33 UTC

[PR] arch/x86_64:Add CXX configuration for enabling x86_64 support for C++… [nuttx]

cuiziwei1 opened a new pull request, #14405:
URL: https://github.com/apache/nuttx/pull/14405

   … applications.
   
   ## Summary
   If enable cxx config, we need add some flags.
   
   ## Impact
   x86_64 enable cxx config
   
   ## Testing
   ci


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64:Add CXX configuration for enabling x86_64 support for C++… [nuttx]

Posted by "nuttxpr (via GitHub)" <gi...@apache.org>.
nuttxpr commented on PR #14405:
URL: https://github.com/apache/nuttx/pull/14405#issuecomment-2422548785

   [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
   
   
   
   This pull request **does not meet** the NuttX requirements. 
   
   **Missing Information:**
   
   * **Summary:**
       *  **Why** is the change necessary?  What problem does it solve? What are the benefits? Simply stating "If enable cxx config, we need add some flags" is not descriptive enough.
       * **What** specific flags are being added?
       * **How** do these flags affect the build process and/or the resulting application?
   * **Impact:**
       * The impact section is too vague. Be specific about:
           * **What applications** are affected by enabling the C++ configuration on x86_64?
           * Are there any **potential compatibility issues** with existing applications?
   * **Testing:**
       * Simply stating "ci" is insufficient.  Provide details about the testing environment and the results:
           * **What specific CI platform** was used?
           * **Which architectures and boards** were tested?
           * Include relevant snippets from the **build logs** and **application output** (both before and after the change) to demonstrate the effect of the modifications. 
   
   **Recommendations:**
   
   1. **Elaborate on the Summary:**  Provide a clear and concise explanation of the purpose, functionality, and benefits of the changes. 
   2. **Be Specific in the Impact Section:** Detail the exact impact on users, build processes, and applications.
   3. **Provide Detailed Testing Information:** Include specific details about the testing environment, procedures, and results.  Offer relevant log snippets that clearly showcase the changes in action. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] arch/x86_64:Add CXX configuration for enabling x86_64 support for C++… [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14405:
URL: https://github.com/apache/nuttx/pull/14405


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org