[GitHub] [iceberg] twalthr commented on a change in pull request #1956: Flink: Upgrade version from 1.11.0 to 1.12.1

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r567688796



##########
File path: flink/src/test/java/org/apache/iceberg/flink/TestFlinkCatalogTable.java
##########
@@ -83,8 +83,8 @@ public void testGetTable() {
             Types.NestedField.optional(1, "strV", Types.StringType.get())));
     Assert.assertEquals(
         Arrays.asList(
-            TableColumn.of("id", DataTypes.BIGINT()),
-            TableColumn.of("strV", DataTypes.STRING())),
+            TableColumn.physical("id", DataTypes.BIGINT()),

Review comment:
       sorry, this API break was a mistake and will be fixed in the next bugfix release
   https://issues.apache.org/jira/browse/FLINK-21226




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org