You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Weiqing Yang <ya...@gmail.com> on 2017/05/15 21:11:11 UTC
Review Request 59295: The credential cache for livy is messed up
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Bugs: AMBARI-21028
https://issues.apache.org/jira/browse/AMBARI-21028
Repository: ambari
Description
-------
The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
Diffs
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
Diff: https://reviews.apache.org/r/59295/diff/1/
Testing
-------
Manually.
Thanks,
Weiqing Yang
Re: Review Request 59295: The credential cache for livy is messed up
Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/#review175191
-----------------------------------------------------------
Ship it!
Ship It!
- Sumit Mohanty
On May 15, 2017, 10:25 p.m., Weiqing Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59295/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 10:25 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-21028
> https://issues.apache.org/jira/browse/AMBARI-21028
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
>
>
> Diff: https://reviews.apache.org/r/59295/diff/3/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Weiqing Yang
>
>
Re: Review Request 59295: The credential cache for livy is messed up
Posted by Weiqing Yang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/
-----------------------------------------------------------
(Updated May 15, 2017, 10:25 p.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Fix review comments
Bugs: AMBARI-21028
https://issues.apache.org/jira/browse/AMBARI-21028
Repository: ambari
Description
-------
The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
Diff: https://reviews.apache.org/r/59295/diff/3/
Changes: https://reviews.apache.org/r/59295/diff/2-3/
Testing
-------
Manually.
Thanks,
Weiqing Yang
Re: Review Request 59295: The credential cache for livy is messed up
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/#review175031
-----------------------------------------------------------
Please run unit tests,
cd ambari-server/src/test/python && python unitTests.py
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py
Line 85 (original), 85 (patched)
<https://reviews.apache.org/r/59295/#comment248349>
this should be configurations[SMOKEUSER_KEY]
- Alejandro Fernandez
On May 15, 2017, 9:33 p.m., Weiqing Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59295/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 9:33 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-21028
> https://issues.apache.org/jira/browse/AMBARI-21028
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
>
>
> Diff: https://reviews.apache.org/r/59295/diff/2/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Weiqing Yang
>
>
Re: Review Request 59295: The credential cache for livy is messed up
Posted by Weiqing Yang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/
-----------------------------------------------------------
(Updated May 15, 2017, 9:33 p.m.)
Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
Changes
-------
Fixed review comments.
Bugs: AMBARI-21028
https://issues.apache.org/jira/browse/AMBARI-21028
Repository: ambari
Description
-------
The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
Diff: https://reviews.apache.org/r/59295/diff/2/
Changes: https://reviews.apache.org/r/59295/diff/1-2/
Testing
-------
Manually.
Thanks,
Weiqing Yang
Re: Review Request 59295: The credential cache for livy is messed up
Posted by Weiqing Yang <ya...@gmail.com>.
> On May 15, 2017, 9:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py
> > Lines 41 (patched)
> > <https://reviews.apache.org/r/59295/diff/1/?file=1719992#file1719992line41>
> >
> > Can retrieve this from cluster-env/smokeuser property
Yes. The patch has been updated. Thanks.
- Weiqing
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/#review175026
-----------------------------------------------------------
On May 15, 2017, 9:11 p.m., Weiqing Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59295/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 9:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-21028
> https://issues.apache.org/jira/browse/AMBARI-21028
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
>
>
> Diff: https://reviews.apache.org/r/59295/diff/1/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Weiqing Yang
>
>
Re: Review Request 59295: The credential cache for livy is messed up
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59295/#review175026
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py
Lines 41 (patched)
<https://reviews.apache.org/r/59295/#comment248345>
Can retrieve this from cluster-env/smokeuser property
- Alejandro Fernandez
On May 15, 2017, 9:11 p.m., Weiqing Yang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59295/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 9:11 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
>
>
> Bugs: AMBARI-21028
> https://issues.apache.org/jira/browse/AMBARI-21028
>
>
> Repository: ambari
>
>
> Description
> -------
>
> The livy smoke test launched by Ambari is run as livy user, but kinits as ambari-qa, and therefore messes up the credential cache for livy. This patch is to fix this issue.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/package/scripts/alerts/alert_spark_livy_port.py 746a98e
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/alerts/alert_spark2_livy_port.py 44c284f
>
>
> Diff: https://reviews.apache.org/r/59295/diff/1/
>
>
> Testing
> -------
>
> Manually.
>
>
> Thanks,
>
> Weiqing Yang
>
>