[GitHub] [superset] dpgaspar commented on a diff in pull request #24499: chore: remove marshmallow-enum dependency and bump FAB

["dpgaspar (via GitHub)" <gi...@apache.org>]

dpgaspar commented on code in PR #24499:
URL: https://github.com/apache/superset/pull/24499#discussion_r1242149402


##########
tests/integration_tests/base_api_tests.py:
##########
@@ -115,7 +115,7 @@ def test_default_missing_declaration_put_spec(self):
         self.assertEqual(rv.status_code, 200)
         response = json.loads(rv.data.decode("utf-8"))
         expected_mutation_spec = {
-            "properties": {"id": {"format": "int32", "type": "integer"}},

Review Comment:
   it's actually a change done on apispec: https://github.com/marshmallow-code/apispec/pull/595
   
   breaking change on 4.0.0



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org