[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #11522: [Improvement][TaskInstance] reduce database queries

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #11522:
URL: https://github.com/apache/dolphinscheduler/pull/11522#discussion_r950994635


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/TaskInstanceMapper.java:
##########
@@ -53,6 +53,9 @@ TaskInstance queryByInstanceIdAndName(@Param("processInstanceId") int processIns
     TaskInstance queryByInstanceIdAndCode(@Param("processInstanceId") int processInstanceId,
                                           @Param("taskCode") Long taskCode);
 
+    List<TaskInstance> queryByInstanceIdsAndCodes(@Param("processInstanceIds") List<Integer> processInstanceIds,

Review Comment:
   ```suggestion
       List<TaskInstance> queryByProcessInstanceIdsAndTaskCodes(@Param("processInstanceIds") List<Integer> processInstanceIds,
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org