You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/06/11 11:54:53 UTC

[GitHub] [calcite] danny0405 commented on a change in pull request #2015: [CALCITE-4055] RelFieldTrimmer loses hints

danny0405 commented on a change in pull request #2015:
URL: https://github.com/apache/calcite/pull/2015#discussion_r438729544



##########
File path: core/src/main/java/org/apache/calcite/tools/RelBuilder.java
##########
@@ -2718,11 +2718,15 @@ public RelBuilder hints(RelHint... hints) {
    */
   public RelBuilder hints(Iterable<RelHint> hints) {
     Objects.requireNonNull(hints);
+    final ImmutableList<RelHint> relHintList = ImmutableList.copyOf(hints);
+    if (relHintList.isEmpty()) {
+      return this;
+    }

Review comment:
       No need to make the hint list immutable, we would do that when attaching.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org