You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by kl0u <gi...@git.apache.org> on 2017/01/20 15:09:34 UTC
[GitHub] flink pull request #3180: [FLINK-5532] Make window assigners for aligned win...
GitHub user kl0u opened a pull request:
https://github.com/apache/flink/pull/3180
[FLINK-5532] Make window assigners for aligned window operators non-extendable
Makes the TumblingAlignedProcessingTimeWindows and the
SlidingAlignedProcessingTimeWindows final so that users cannot
extend them.
R @aljoscha @StephanEwen
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kl0u/flink non-extendable-aligned
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3180.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3180
----
commit 82bb3519e5bb024774795adcded0a51d9bc2fa4c
Author: kl0u <kk...@gmail.com>
Date: 2017-01-20T13:31:48Z
[FLINK-5532] Make window assigners for aligned window ops non-extendable
Makes the TumblingAlignedProcessingTimeWindows and the
SlidingAlignedProcessingTimeWindows final so that users cannot
extend them.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3180: [FLINK-5532] Make window assigners for aligned win...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3180#discussion_r97283576
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java ---
@@ -35,7 +35,7 @@
* <p>
* <b>WARNING:</b> Bear in mind that no rescaling and no backwards compatibility is supported.
* */
-public class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner {
+public final class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner {
--- End diff --
This class does not have an annotation.
Should we add `@PublicEvolving`?
Same is true for the `TumblingAlignedProcessingTImeWindows`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3180: [FLINK-5532] Make window assigners for aligned window ope...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/3180
+1 to merge this, modulo Fabian's comment...
merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3180: [FLINK-5532] Make window assigners for aligned win...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3180
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3180: [FLINK-5532] Make window assigners for aligned win...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/3180#discussion_r97283933
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java ---
@@ -35,7 +35,7 @@
* <p>
* <b>WARNING:</b> Bear in mind that no rescaling and no backwards compatibility is supported.
* */
-public class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner {
+public final class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner {
--- End diff --
You are right @fhueske . I will make them `@deprecated` and `@PublicEvolving`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3180: [FLINK-5532] Make window assigners for aligned win...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on a diff in the pull request:
https://github.com/apache/flink/pull/3180#discussion_r97283937
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/assigners/SlidingAlignedProcessingTimeWindows.java ---
@@ -35,7 +35,7 @@
* <p>
* <b>WARNING:</b> Bear in mind that no rescaling and no backwards compatibility is supported.
* */
-public class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner {
+public final class SlidingAlignedProcessingTimeWindows extends BaseAlignedWindowAssigner {
--- End diff --
Yes, they should be `@PublicEvolving`.
Will add that when merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3180: [FLINK-5532] Make window assigners for aligned window ope...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on the issue:
https://github.com/apache/flink/pull/3180
Thanks @fhueske and @StephanEwen !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---