[GitHub] [spark] xuanyuanking opened a new pull request #26229: [SPARK-21492][SQL][Follow Up] Reimplement UnsafeExternalRowSorter in database style iterator

[GitBox <gi...@apache.org>]

xuanyuanking opened a new pull request #26229: [SPARK-21492][SQL][Follow Up] Reimplement UnsafeExternalRowSorter in database style iterator
URL: https://github.com/apache/spark/pull/26229
 
 
   ### What changes were proposed in this pull request?
   Reimplement the iterator in UnsafeExternalRowSorter in database style. This can be done by reusing the `RowIterator` in our code base.
   
   ### Why are the changes needed?
   During the job in #26164, after involving a var `isReleased` in `hasNext`, there's possible that `isReleased` is false when calling `hasNext`, but it becomes true before calling `next`. A safer way is using database-style iterator: `advanceNext` and `getRow`.
   
   ### Does this PR introduce any user-facing change?
   No.
   
   
   ### How was this patch tested?
   Existing UT.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org