[GitHub] [iceberg] massdosage edited a comment on pull request #1107: Add IcebergStorageHandler

[GitBox <gi...@apache.org>]

massdosage edited a comment on pull request #1107:
URL: https://github.com/apache/iceberg/pull/1107#issuecomment-663503333


   > This looks good to me, just a couple minor questions. I'll merge this to unblock next steps.
   > 
   > Where does this fit in the overall plan for Hive support? 
   
   Well, this is actually a good milestone as we now have everything that's needed to be able to _read_ Iceberg tables from Hive merged into master. 
   
   Up next we were going to add back in the features like pushdowns, system tables, time travel reads etc. but they're all improvements, what is in Iceberg now should work end to end for the read path. One thing I'd like to change to make this easier to use is for the module to build an uber jar so you only have to add one jar to Hive's classpath instead of 6+ which is the case at the moment. Once that's done we also need to add documentation describing this all.
   
   > Are tests going to be added next? What works right now and what doesn't?
   
   @guilload ended up adding the tests in #1192 - the main test class is [TestHiveIcebergInputFormat](https://github.com/apache/iceberg/blob/master/mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergInputFormat.java). We were planning to flesh that out with more tests as we add in the above features etc.
   
    
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org