[GitHub] [dolphinscheduler] kezhenxu94 commented on a diff in pull request #10052: [Fix-10028][Docker]Support Multi-Architecture Docker Images

[GitBox <gi...@apache.org>]

kezhenxu94 commented on code in PR #10052:
URL: https://github.com/apache/dolphinscheduler/pull/10052#discussion_r874313881


##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -23,6 +23,24 @@ git clone git@github.com:apache/dolphinscheduler.git
 
 ii. Run `mvn clean install -Prelease -Dmaven.test.skip=true`
 
+### Docker image build
+* Run
+```shell
+$ cd dolphinscheduler
+$ ./mvnw -B clean deploy \
+          -Dmaven.test.skip \
+          -Dmaven.javadoc.skip \
+          -Dmaven.checkstyle.skip \
+          -Dmaven.deploy.skip \
+          -Ddocker.tag=<TAG> \
+          -Ddocker.hub=<HUB_URL> \
+          -Pdocker,release          
+```

Review Comment:
   * To build Docker images locally, run
   
   ```shell
   $ cd dolphinscheduler
   $ ./mvnw -B clean package \
             -Dmaven.test.skip \
             -Dmaven.javadoc.skip \
             -Dmaven.checkstyle.skip \
             -Ddocker.tag=<TAG> \
             -Pdocker,release          
   ```
   
   * To build and push Docker images to your registry `<HUB_URL>`, run
   ```shell
   $ cd dolphinscheduler
   $ ./mvnw -B clean deploy \
             -Dmaven.test.skip \
             -Dmaven.javadoc.skip \
             -Dmaven.checkstyle.skip \
             -Dmaven.deploy.skip \
             -Ddocker.tag=<TAG> \
             -Ddocker.hub=<HUB_URL> \
             -Pdocker,release          
   ```



##########
docs/docs/en/development/development-environment-setup.md:
##########
@@ -23,6 +23,24 @@ git clone git@github.com:apache/dolphinscheduler.git
 
 ii. Run `mvn clean install -Prelease -Dmaven.test.skip=true`
 
+### Docker image build
+* Run
+```shell
+$ cd dolphinscheduler
+$ ./mvnw -B clean deploy \
+          -Dmaven.test.skip \
+          -Dmaven.javadoc.skip \
+          -Dmaven.checkstyle.skip \
+          -Dmaven.deploy.skip \
+          -Ddocker.tag=<TAG> \
+          -Ddocker.hub=<HUB_URL> \
+          -Pdocker,release          
+```
+
+> **_Note：_** Docker will build linux/amd64,linux/arm64 multi-architecture images by defult

Review Comment:
   ```suggestion
   > **_Note：_** Docker will build and push linux/amd64,linux/arm64 multi-architecture images by default
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org