You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "lucifer4j (via GitHub)" <gi...@apache.org> on 2023/07/01 06:33:53 UTC

[GitHub] [pinot] lucifer4j opened a new issue, #10924: Implementing PinotClientTransport using Vert.x

lucifer4j opened a new issue, #10924:
URL: https://github.com/apache/pinot/issues/10924

   Hi! I are trying to implement the PinotClientTransport interface as a part of creating a Vert.x Client adapter for the Pinot client. There are two changes we have identified so far that can help move in that direction.
   1. https://github.com/apache/pinot/pull/10326
   2. Making [BrokerResponse](https://github.com/apache/pinot/blob/master/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerResponse.java) a public class. Currently its package private but the public interface of PinotClientTransport returns it from the executeQuery and executeQueryAsync methods making it impossible to implement the interface externally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] lucifer4j commented on issue #10924: Implementing PinotClientTransport using Vert.x

Posted by "lucifer4j (via GitHub)" <gi...@apache.org>.
lucifer4j commented on issue #10924:
URL: https://github.com/apache/pinot/issues/10924#issuecomment-1705075765

   @navina Sorry for the late response, I had totally missed your comment. The repository is https://github.com/reactiverse/pinot-client and the license is Apache 2.0.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] navina commented on issue #10924: Implementing PinotClientTransport using Vert.x

Posted by "navina (via GitHub)" <gi...@apache.org>.
navina commented on issue #10924:
URL: https://github.com/apache/pinot/issues/10924#issuecomment-1598023191

   @lucifer4j thanks for implementing the Vert.x Client adapter for Pinot client. 
   I have some questions on this work which I think is super useful. 
   1. Is the vert.x client adapter implemented as a wrapper around the existing pinot client? Or is it going to be native client built using vert.x's async architecture? 
   2. How does the usage of a vert.x client differ from the existing pinot client ? 
   
   If you have any design or write-up about your work, it will be greatly help us understand the approach and review your work.  Tks! 
   
   
   Label: `pinot-client` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] navina commented on issue #10924: Implementing PinotClientTransport using Vert.x

Posted by "navina (via GitHub)" <gi...@apache.org>.
navina commented on issue #10924:
URL: https://github.com/apache/pinot/issues/10924#issuecomment-1615025457

   @lucifer4j : Thanks for sharing the doc and looking forward to the demo app. 
   
   Follow-up questions:
   1. Is the code for the client going to be in open-source (I am assuming so)? If yes, which is git repository ?
   2. What is the license that will be used by this module?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] lucifer4j commented on issue #10924: Implementing PinotClientTransport using Vert.x

Posted by "lucifer4j (via GitHub)" <gi...@apache.org>.
lucifer4j commented on issue #10924:
URL: https://github.com/apache/pinot/issues/10924#issuecomment-1614197285

   @navina Hi! Thanks.
   
   1. It s a wrapper around the existing Pinot Client. A technical writeup is available at https://docs.google.com/document/d/11zXGTKqyW-kykltpAyA71IDssZ1S04r4iv1AcdR94nc/edit?usp=sharing but it might be a bit dated because of the new information I discovered during the implementation so far.
   2. The usage should be similar to the existing Pinot Client, only the API provided will be Vert.x friendly. I will be making a demo application to demonstrate the use of the wrapper soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] lucifer4j commented on issue #10924: Implementing PinotClientTransport using Vert.x

Posted by "lucifer4j (via GitHub)" <gi...@apache.org>.
lucifer4j commented on issue #10924:
URL: https://github.com/apache/pinot/issues/10924#issuecomment-1705074117

   #11506


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org

[GitHub] [pinot] Jackie-Jiang closed issue #10924: Implementing PinotClientTransport using Vert.x

Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang closed issue #10924: Implementing PinotClientTransport using Vert.x
URL: https://github.com/apache/pinot/issues/10924


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org