You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Chris Riccomini <cr...@apache.org> on 2014/10/30 18:26:22 UTC
Review Request 27389: SAMZA-450
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27389/
-----------------------------------------------------------
Review request for samza.
Repository: samza
Description
-------
only override propertes if they're not set in task.opts for log4j.configuration samza.log.dir samza.container.name java.io.tmpdir
Diffs
-----
samza-shell/src/main/bash/checkpoint-tool.sh 5688b59e32e10f8eeff6ecfd3c3589d08ce8ba8e
samza-shell/src/main/bash/kill-yarn-job.sh d42e08679510c9ed196764ed24965f067d8ace7d
samza-shell/src/main/bash/run-am.sh 4cc4f00a9095132a0a645984f0e3e4c7247d105d
samza-shell/src/main/bash/run-class.sh 155f29b2b1f20c1b72759a349b9156be717cee15
samza-shell/src/main/bash/run-container.sh 4ac375c8d897da7be23ea1592e816ba435e45c27
samza-shell/src/main/bash/run-job.sh d43b556bb0e4f57185c491105e506fd8c9642c1f
Diff: https://reviews.apache.org/r/27389/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 27389: SAMZA-450
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27389/
-----------------------------------------------------------
(Updated Oct. 30, 2014, 7:13 p.m.)
Review request for samza.
Repository: samza
Description (updated)
-------
fix run-container to set name and id if environment variable is not empty
export required to set JAVA_OPTS in run-class.sh wrappers
only override propertes if they're not set in task.opts for log4j.configuration samza.log.dir samza.container.name java.io.tmpdir
Diffs (updated)
-----
samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 7504e6d431dad46d23c41a99d5a0d6068afb84e7
samza-shell/src/main/bash/checkpoint-tool.sh 5688b59e32e10f8eeff6ecfd3c3589d08ce8ba8e
samza-shell/src/main/bash/kill-yarn-job.sh d42e08679510c9ed196764ed24965f067d8ace7d
samza-shell/src/main/bash/run-am.sh 4cc4f00a9095132a0a645984f0e3e4c7247d105d
samza-shell/src/main/bash/run-class.sh 155f29b2b1f20c1b72759a349b9156be717cee15
samza-shell/src/main/bash/run-container.sh 4ac375c8d897da7be23ea1592e816ba435e45c27
samza-shell/src/main/bash/run-job.sh d43b556bb0e4f57185c491105e506fd8c9642c1f
Diff: https://reviews.apache.org/r/27389/diff/
Testing
-------
Thanks,
Chris Riccomini
Re: Review Request 27389: SAMZA-450
Posted by Chinmay Soman <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27389/#review59242
-----------------------------------------------------------
Ship it!
Ship It!
- Chinmay Soman
On Oct. 30, 2014, 6:01 p.m., Chris Riccomini wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27389/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2014, 6:01 p.m.)
>
>
> Review request for samza.
>
>
> Repository: samza
>
>
> Description
> -------
>
> export required to set JAVA_OPTS in run-class.sh wrappers
>
>
> only override propertes if they're not set in task.opts for log4j.configuration samza.log.dir samza.container.name java.io.tmpdir
>
>
> Diffs
> -----
>
> samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 7504e6d431dad46d23c41a99d5a0d6068afb84e7
> samza-shell/src/main/bash/checkpoint-tool.sh 5688b59e32e10f8eeff6ecfd3c3589d08ce8ba8e
> samza-shell/src/main/bash/kill-yarn-job.sh d42e08679510c9ed196764ed24965f067d8ace7d
> samza-shell/src/main/bash/run-am.sh 4cc4f00a9095132a0a645984f0e3e4c7247d105d
> samza-shell/src/main/bash/run-class.sh 155f29b2b1f20c1b72759a349b9156be717cee15
> samza-shell/src/main/bash/run-container.sh 4ac375c8d897da7be23ea1592e816ba435e45c27
> samza-shell/src/main/bash/run-job.sh d43b556bb0e4f57185c491105e506fd8c9642c1f
>
> Diff: https://reviews.apache.org/r/27389/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Chris Riccomini
>
>
Re: Review Request 27389: SAMZA-450
Posted by Chris Riccomini <cr...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27389/
-----------------------------------------------------------
(Updated Oct. 30, 2014, 6:01 p.m.)
Review request for samza.
Repository: samza
Description (updated)
-------
export required to set JAVA_OPTS in run-class.sh wrappers
only override propertes if they're not set in task.opts for log4j.configuration samza.log.dir samza.container.name java.io.tmpdir
Diffs (updated)
-----
samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala 7504e6d431dad46d23c41a99d5a0d6068afb84e7
samza-shell/src/main/bash/checkpoint-tool.sh 5688b59e32e10f8eeff6ecfd3c3589d08ce8ba8e
samza-shell/src/main/bash/kill-yarn-job.sh d42e08679510c9ed196764ed24965f067d8ace7d
samza-shell/src/main/bash/run-am.sh 4cc4f00a9095132a0a645984f0e3e4c7247d105d
samza-shell/src/main/bash/run-class.sh 155f29b2b1f20c1b72759a349b9156be717cee15
samza-shell/src/main/bash/run-container.sh 4ac375c8d897da7be23ea1592e816ba435e45c27
samza-shell/src/main/bash/run-job.sh d43b556bb0e4f57185c491105e506fd8c9642c1f
Diff: https://reviews.apache.org/r/27389/diff/
Testing
-------
Thanks,
Chris Riccomini