[GitHub] [struts] lukaszlenart commented on a diff in pull request #687: WW-5301 Fix custom VelocityManager bean selection

["lukaszlenart (via GitHub)" <gi...@apache.org>]

lukaszlenart commented on code in PR #687:
URL: https://github.com/apache/struts/pull/687#discussion_r1200071200


##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -109,6 +108,8 @@ public class Dispatcher {
 
     public static final String MULTIPART_FORM_DATA_REGEX = "^multipart/form-data(?:\\s*;\\s*boundary=[0-9a-zA-Z'()+_,\\-./:=?]{1,70})?(?:\\s*;\\s*charset=[a-zA-Z\\-0-9]{3,14})?";
 
+    private static final String CONFIG_SPLIT_REGEX = "\\s*,\\s*";

Review Comment:
   👏 



##########
core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java:
##########
@@ -554,6 +566,7 @@ public void init() {
             init_CustomConfigurationProviders(); // [5]
             init_FilterInitParameters(); // [6]
             init_AliasStandardObjects(); // [7]
+            init_DeferredXmlConfigurations();

Review Comment:
   Nice, do you plan document this functionality in the docs?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org