[GitHub] [solr] dsmiley commented on pull request #1320: SOLR-16641 - Generate gradle.properties from gradlew

["dsmiley (via GitHub)" <gi...@apache.org>]

dsmiley commented on PR #1320:
URL: https://github.com/apache/solr/pull/1320#issuecomment-1412104815

   > without messing around with gitignore
   
   What many people don't realize about `.gitignore` is that it does *not* prevent the file being a part of the repo (i.e. committed & pulled).  We can absolutely put a real default safe (albeit slow) `gradle.properties` here and the *existing* `.gitignore` rule that *already* references `gradle.properties` will prevent someone from _accidentally_ committing their changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org