You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2024/03/25 15:58:37 UTC
[PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]
XComp opened a new pull request, #24562:
URL: https://github.com/apache/flink/pull/24562
## What is the purpose of the change
See FLINK-34933 for motivation
## Brief change log
* Adds default implementation for `TestingJobMasterServiceProcess#closeAsync` returning a complete future
* Makes the test verify that the `resultFuture` isn't completed until the runner is closed.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]
Posted by "zentol (via GitHub)" <gi...@apache.org>.
zentol commented on code in PR #24562:
URL: https://github.com/apache/flink/pull/24562#discussion_r1542463838
##########
flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunnerTest.java:
##########
@@ -499,11 +499,33 @@ void testResultFutureCompletionOfOutdatedLeaderIsIgnored() throws Exception {
leaderElection.notLeader();
+ assertThat(jobManagerRunner.getResultFuture())
+ .as("The runner result should not be completed by the leadership revocation.")
+ .isNotDone();
+
resultFuture.complete(
JobManagerRunnerResult.forSuccess(
createFailedExecutionGraphInfo(new FlinkException("test exception"))));
- assertThatFuture(jobManagerRunner.getResultFuture()).eventuallyFails();
+ assertThat(jobManagerRunner.getResultFuture())
+ .as("The runner result should be completed if the leadership is lost.")
+ .isNotDone();
Review Comment:
the message doesnt match the assertion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]
Posted by "XComp (via GitHub)" <gi...@apache.org>.
XComp merged PR #24562:
URL: https://github.com/apache/flink/pull/24562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-34933][test] Fixes JobMasterServiceLeadershipRunnerTest#testResultFutureCompletionOfOutdatedLeaderIsIgnored [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24562:
URL: https://github.com/apache/flink/pull/24562#issuecomment-2018360524
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "6761fcb9af9efe341ef3a8b9474c359d46c66186",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "6761fcb9af9efe341ef3a8b9474c359d46c66186",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 6761fcb9af9efe341ef3a8b9474c359d46c66186 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org