You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2016/01/06 14:33:32 UTC

Review Request 41977: Renaming cluster in Ambari breaks alerts

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41977/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez and Nate Cole.


Bugs: AMBARI-14565
    https://issues.apache.org/jira/browse/AMBARI-14565


Repository: ambari


Description
-------

After renaming a cluster using the admin view, the following error messages are seen in the logs:

HeartBeatHandler:306 - Unable to process alerts because the cluster Analytics does not exist
hdpm-m610-3-ambari-server.log:28 Jul 2015 14:45:42,960  WARN [qtp-ambari-agent-325199] HeartBeatHandler:306 - Unable to process alerts because the cluster Analytics does not exist
hdpm-m610-3-ambari-server.log:28 Jul 2015 14:45:42,960  WARN [qtp-ambari-agent-325199] 

This is because the hash for the alert definitions never changes and the alert jobs are never rescheduled.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 3e89437 
  ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py dc7fe0a 
  ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java 4c9641d 
  ambari-server/src/main/java/org/apache/ambari/server/events/AlertReceivedEvent.java 23d29bb 
  ambari-server/src/main/java/org/apache/ambari/server/events/AlertStateChangeEvent.java e637709 
  ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java d5c14fb 
  ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java 8df881b 
  ambari-server/src/main/java/org/apache/ambari/server/events/HostRemovedEvent.java 2d1978c 
  ambari-server/src/main/java/org/apache/ambari/server/events/InitialAlertEvent.java a718fae 
  ambari-server/src/main/java/org/apache/ambari/server/events/MaintenanceModeEvent.java 810cab4 
  ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java 399637d 
  ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java d497c20 
  ambari-server/src/main/java/org/apache/ambari/server/events/ServiceInstalledEvent.java c2b6e7a 
  ambari-server/src/main/java/org/apache/ambari/server/events/ServiceRemovedEvent.java 9715863 
  ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java b5f351e 
  ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 6c0a839 
  ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 35c10e9 
  ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 54bed42 

Diff: https://reviews.apache.org/r/41977/diff/


Testing
-------

mvn clean test


Thanks,

Jonathan Hurley


Re: Review Request 41977: Renaming cluster in Ambari breaks alerts

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41977/#review113097
-----------------------------------------------------------

Ship it!


Ship It!

- Alejandro Fernandez


On Jan. 6, 2016, 1:33 p.m., Jonathan Hurley wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41977/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 1:33 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-14565
>     https://issues.apache.org/jira/browse/AMBARI-14565
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After renaming a cluster using the admin view, the following error messages are seen in the logs:
> 
> HeartBeatHandler:306 - Unable to process alerts because the cluster Analytics does not exist
> hdpm-m610-3-ambari-server.log:28 Jul 2015 14:45:42,960  WARN [qtp-ambari-agent-325199] HeartBeatHandler:306 - Unable to process alerts because the cluster Analytics does not exist
> hdpm-m610-3-ambari-server.log:28 Jul 2015 14:45:42,960  WARN [qtp-ambari-agent-325199] 
> 
> This is because the hash for the alert definitions never changes and the alert jobs are never rescheduled.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AlertSchedulerHandler.py 3e89437 
>   ambari-agent/src/main/python/ambari_agent/ClusterConfiguration.py dc7fe0a 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AggregateAlertRecalculateEvent.java 4c9641d 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AlertReceivedEvent.java 23d29bb 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AlertStateChangeEvent.java e637709 
>   ambari-server/src/main/java/org/apache/ambari/server/events/AmbariEvent.java d5c14fb 
>   ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionEvent.java 8df881b 
>   ambari-server/src/main/java/org/apache/ambari/server/events/HostRemovedEvent.java 2d1978c 
>   ambari-server/src/main/java/org/apache/ambari/server/events/InitialAlertEvent.java a718fae 
>   ambari-server/src/main/java/org/apache/ambari/server/events/MaintenanceModeEvent.java 810cab4 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentInstalledEvent.java 399637d 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceComponentUninstalledEvent.java d497c20 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceInstalledEvent.java c2b6e7a 
>   ambari-server/src/main/java/org/apache/ambari/server/events/ServiceRemovedEvent.java 9715863 
>   ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertHashInvalidationListener.java b5f351e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/alert/AlertDefinitionHash.java 6c0a839 
>   ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java 35c10e9 
>   ambari-server/src/test/java/org/apache/ambari/server/events/EventsTest.java 54bed42 
> 
> Diff: https://reviews.apache.org/r/41977/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>