You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/02/07 10:29:00 UTC

[jira] [Commented] (GEODE-7772) Simplify hasNext in PageableLuceneQueryResultsImpl

    [ https://issues.apache.org/jira/browse/GEODE-7772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032278#comment-17032278 ] 

ASF subversion and git services commented on GEODE-7772:
--------------------------------------------------------

Commit 93aa3c4668f888e62d7951c1712c179955b6d01b in geode's branch refs/heads/develop from mkevo
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=93aa3c4 ]

GEODE-7772: Simplify hasNext in PageableLuceneQueryResultsImpl (#4678)



> Simplify hasNext in PageableLuceneQueryResultsImpl
> --------------------------------------------------
>
>                 Key: GEODE-7772
>                 URL: https://issues.apache.org/jira/browse/GEODE-7772
>             Project: Geode
>          Issue Type: Task
>          Components: lucene
>            Reporter: Jason Huynh
>            Assignee: Mario Kevo
>            Priority: Major
>              Labels: beginner, newb, starter
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The if statement in the hasNext() method can be simplified by condensing into a single line return statement.
> See here:
> [https://github.com/apache/geode/blob/182de42d8e56a900f0d22793a440af72f62f09f4/geode-lucene/src/main/java/org/apache/geode/cache/lucene/internal/PageableLuceneQueryResultsImpl.java#L149] 
> Example, and possibly correct fix:
> {code:java}
> return !currentPage.isEmpty();{code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)