You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@openoffice.apache.org by Pavel Janík <Pa...@Janik.cz> on 2012/08/16 13:25:53 UTC

Re: svn commit: r1373695 - in /incubator/ooo/trunk/main: filter/inc/filter/msfilter/escherex.hxx filter/inc/filter/msfilter/msdffimp.hxx filter/source/msfilter/escherex.cxx filter/source/msfilter/msdffimp.cxx sd/source/filter/eppt/epptso.cxx

Hi,

On Aug 16, 2012, at 4:13 AM, lijiany@apache.org wrote:

> Author: lijiany
> Date: Thu Aug 16 02:13:03 2012
> New Revision: 1373695
> 
>    incubator/ooo/trunk/main/filter/inc/filter/msfilter/escherex.hxx

The changes in this file are not WaE clean. Please fix this.

/Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx: In member function ‘void EscherPropertyContainer::CreateGradientProperties(const com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>&, sal_Bool)’:
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:510: warning: comparison between ‘enum com::sun::star::awt::GradientStyle’ and ‘enum GradientStyle’
/Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:498: warning: enumeration value ‘GradientStyle_MAKE_FIXED_SIZE’ not handled in switch

-- 
Pavel Janík

Re: svn commit: r1373695 - in /incubator/ooo/trunk/main: filter/inc/filter/msfilter/escherex.hxx filter/inc/filter/msfilter/msdffimp.hxx filter/source/msfilter/escherex.cxx filter/source/msfilter/msdffimp.cxx sd/source/filter/eppt/epptso.cxx

Posted by Jianyuan Li <li...@gmail.com>.

Thanks Pavel. I will add this parameter on configure.

2012/8/17 Pavel Janík <Pa...@janik.cz>

>
> On Aug 17, 2012, at 7:23 AM, Jianyuan Li wrote:
>
> > Thanks for the reminder. Done in revision 1374138.
> > BTW, can you show me how you found this kind of warning? Is there any
> tools
> > or guide?
>
> Just build with WaE, so add --enable-werror to configure.
> --
> Pavel Janík
>
>
>
>

Re: svn commit: r1373695 - in /incubator/ooo/trunk/main: filter/inc/filter/msfilter/escherex.hxx filter/inc/filter/msfilter/msdffimp.hxx filter/source/msfilter/escherex.cxx filter/source/msfilter/msdffimp.cxx sd/source/filter/eppt/epptso.cxx

Posted by Pavel Janík <Pa...@Janik.cz>.

On Aug 17, 2012, at 7:23 AM, Jianyuan Li wrote:

> Thanks for the reminder. Done in revision 1374138.
> BTW, can you show me how you found this kind of warning? Is there any tools
> or guide?

Just build with WaE, so add --enable-werror to configure.
-- 
Pavel Janík

Re: svn commit: r1373695 - in /incubator/ooo/trunk/main: filter/inc/filter/msfilter/escherex.hxx filter/inc/filter/msfilter/msdffimp.hxx filter/source/msfilter/escherex.cxx filter/source/msfilter/msdffimp.cxx sd/source/filter/eppt/epptso.cxx

Posted by Jianyuan Li <li...@gmail.com>.

Hi, Pavel,

Thanks for the reminder. Done in revision 1374138.
BTW, can you show me how you found this kind of warning? Is there any tools
or guide?

Regards,
Jianyuan



2012/8/16 Pavel Janík <Pa...@janik.cz>

> Hi,
>
> On Aug 16, 2012, at 4:13 AM, lijiany@apache.org wrote:
>
> > Author: lijiany
> > Date: Thu Aug 16 02:13:03 2012
> > New Revision: 1373695
> >
> >    incubator/ooo/trunk/main/filter/inc/filter/msfilter/escherex.hxx
>
> The changes in this file are not WaE clean. Please fix this.
>
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:
> In member function ‘void
> EscherPropertyContainer::CreateGradientProperties(const
> com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet>&,
> sal_Bool)’:
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:510:
> warning: comparison between ‘enum com::sun::star::awt::GradientStyle’ and
> ‘enum GradientStyle’
> /Users/pavel/BUILD/BuildDir/ooo_trunk_src/filter/source/msfilter/escherex.cxx:498:
> warning: enumeration value ‘GradientStyle_MAKE_FIXED_SIZE’ not handled in
> switch
>
> --
> Pavel Janík
>
>
>
>