You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by robertamarton <gi...@git.apache.org> on 2015/12/11 18:35:28 UTC
[GitHub] incubator-trafodion pull request: TRAFODION-1704: T2 and T4 driver...
GitHub user robertamarton opened a pull request:
https://github.com/apache/incubator-trafodion/pull/224
TRAFODION-1704: T2 and T4 driver cleanup
Removed obsolete files from T2, redesigned result set code for T4 driver code
so same files can be removed.
Removed BaseRow.java, Row.java, and InsertRow.java from T2 and T4 code
Added ObjectArray.java to T4 code to store and manage an array of objects
TRAFODION-1642 Release 1.3.0 copyrights and license files are incorrect
Part 3 of cleaning up copyrights and license files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertamarton/incubator-trafodion t2t4
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/224.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #224
----
commit 53ef0961c63fb5d81d0b67fbb305f8dda5c4a091
Author: Roberta Marton <ro...@esgyn.com>
Date: 2015-12-11T01:47:31Z
TRAFODION-1704: T2 and T4 driver cleanup
Removed obsolete files from T2, redesigned result set code for T4 driver code
so same files can be removed.
Removed BaseRow.java, Row.java, and InsertRow.java from T2 and T4 code
Added ObjectArray.java to T4 code to store and manage an array of objects
TRAFODION-1642 Release 1.3.0 copyrights and license files are incorrect
Part 3 of cleaning up copyrights and license files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1704: T2 and T4 driver...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/224#discussion_r47417030
--- Diff: core/sql/common/multi-byte.h ---
@@ -18,12 +18,6 @@
// under the License.
//
// @@@ END COPYRIGHT @@@
-/*
--- End diff --
Could you explain the provenance behind this code (and other similar files below) that allows us to remove these copyrights?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1704: T2 and T4 driver...
Posted by robertamarton <gi...@git.apache.org>.
Github user robertamarton commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/224#discussion_r47530779
--- Diff: core/sql/common/multi-byte.h ---
@@ -18,12 +18,6 @@
// under the License.
//
// @@@ END COPYRIGHT @@@
-/*
--- End diff --
Hewlett Packard donated the original Trafodion code to Apache. HP is a founding member of the Open Software Foundation and has all rights to code produced under this license. Therefore these copyrights are covered by the same agreement that allows us to remove HP copyrights. This information came from a conversion I had with the team that handled the software donation from HP to Apache.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1704: T2 and T4 driver...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/224#discussion_r47416361
--- Diff: README.txt ---
@@ -12,24 +12,25 @@ Hadoop.
To get started using Apache Trafodion:
- documentation for this release can be viewed on the Apache Trafodion
- wiki page:
- https://cwiki.apache.org/confluence/display/TRAFODION/Documentation
+ web page:
+ http://trafodion.apache.org/documentation.html
- release notes describing changes for release 1.3.0 can be viewed:
- https://cwiki.apache.org/confluence/display/TRAFODION/Software
+ http://trafodion.apache.org/release-notes-1-3-0.html
- the latest Apache Trafodion can be downloaded from Apache incubator
distribution site or accessed from git
- - download site:
+ = download site:
https://dist.apache.org/repos/dist/release/incubator/trafodion
- - git site:
+ = git site:
git@github.com:apache/incubator-trafodion
- To build and try out Apache Trafodion, please following our build
--- End diff --
Grammar: "please following" should be "please follow"... can change on a subsequent commit if you like. Also, would be good to make the capitalization of the bullets consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: TRAFODION-1704: T2 and T4 driver...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---