You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "destrex271 (via GitHub)" <gi...@apache.org> on 2025/09/04 19:27:52 UTC
[PR] fix: updated `output_ordering` in file_scan_config.rs to use Vec> instead of just Vec [datafusion]
destrex271 opened a new pull request, #17423:
URL: https://github.com/apache/datafusion/pull/17423
## Which issue does this PR close?
- Closes #17354
## What changes are included in this PR?
- Updated the type of output_ordering in `FileScanConfig` to `Vec<Option<LexOrdering>>`
- Updated the `get_projected_output_ordering` function in file_scan_config.rs to return Vec<Option<LexOrdering>>
- Handle output generated by `get_projected_output_ordering` in various places by falttening the result and reconstructing `Vec<LexOrdering>` from `Vec<Option<LexOrdering>>` (This might need some discussion/additional reviews)
## Are these changes tested?
No new tests were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: updated `output_ordering` in file_scan_config.rs to use Vec> instead of just Vec [datafusion]
Posted by "destrex271 (via GitHub)" <gi...@apache.org>.
destrex271 commented on PR #17423:
URL: https://github.com/apache/datafusion/pull/17423#issuecomment-3257612097
@xudong963 , closing this PR to open a separate one since the rebase has altered a lot of files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: updated `output_ordering` in file_scan_config.rs to use Vec> instead of just Vec [datafusion]
Posted by "destrex271 (via GitHub)" <gi...@apache.org>.
destrex271 closed pull request #17423: fix: updated `output_ordering` in file_scan_config.rs to use Vec<Option<LexOrdering>> instead of just Vec<LexOrdering>
URL: https://github.com/apache/datafusion/pull/17423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] fix: updated `output_ordering` in file_scan_config.rs to use Vec> instead of just Vec [datafusion]
Posted by "xudong963 (via GitHub)" <gi...@apache.org>.
xudong963 commented on code in PR #17423:
URL: https://github.com/apache/datafusion/pull/17423#discussion_r2324294010
##########
testing:
##########
Review Comment:
ditto
##########
parquet-testing:
##########
Review Comment:
This shouldn't be changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org