You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "wolftxt (via GitHub)" <gi...@apache.org> on 2025/09/11 19:47:18 UTC
[PR] Resolves #4710 a Close Right feature in menu [netbeans]
wolftxt opened a new pull request, #8817:
URL: https://github.com/apache/netbeans/pull/8817
An implementation of https://github.com/apache/netbeans/issues/4710
Implements an Action seen in the popup shown when right-clicking an opened file and a button in the Menu Bar. (see screenshot)
<img width="711" height="568" alt="screenshot" src="https://github.com/user-attachments/assets/9921aaf2-69be-499f-b30c-22407a9f5e7b" />
The Menu button is disabled when a different menu is selected.
## IMPORTANT
I also implemented the feature in https://github.com/wolftxt/netbeans/commit/ee5dff62c5502a3180efbe867f4c4832189acfac#diff-71678d0b96847081e80dbff752c8f8fbd5ddb104b0aca14c5f647b0d5577a890R330-R332
and in
https://github.com/wolftxt/netbeans/commit/ee5dff62c5502a3180efbe867f4c4832189acfac#diff-bcff9302585f23230582eec38b02969456405f636b6c490c3e9c10e8c8c83e23R195
(Classes TabbedHandler and TabbedContainer)
Even through i don't think this part of the code does anything, but I implemented close right here as well just in case. I do not believe that this part of the code does anything because I was not able to reproduce any other string values of the cmd variable other than "select" or "popup".
Therefore I think that this part (along with all other parts of this method that depend on the variable cmd being any different than "select" or "popup") should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists