You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Jun Rao <ju...@gmail.com> on 2014/04/02 20:49:24 UTC
Review Request 19953: Patch for KAFKA-1303
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19953/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1303
https://issues.apache.org/jira/browse/KAFKA-1303
Repository: kafka
Description
-------
Changes are described in the comment of selectMetadataDestination().
1. Added the logic to use bootstrap cluster if no node can be selected from the real cluster. 2. Fixed the issue that node is not selected randomally.
Diffs
-----
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 855ae84f14aa91653b3fa855c2af40560323f42a
Diff: https://reviews.apache.org/r/19953/diff/
Testing
-------
Thanks,
Jun Rao
Re: Review Request 19953: Patch for KAFKA-1303
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19953/#review39343
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71700>
I wonder if it's possible to add a test for this?
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71702>
The node selection doesn't seem to be random though, it seems like it's going to favor the lower broker nodes first?
- Timothy Chen
On April 2, 2014, 6:49 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19953/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 6:49 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1303
> https://issues.apache.org/jira/browse/KAFKA-1303
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Changes are described in the comment of selectMetadataDestination().
>
>
> 1. Added the logic to use bootstrap cluster if no node can be selected from the real cluster. 2. Fixed the issue that node is not selected randomally.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 855ae84f14aa91653b3fa855c2af40560323f42a
>
> Diff: https://reviews.apache.org/r/19953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 19953: Patch for KAFKA-1303
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19953/#review39399
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71801>
Can we remove this sentence now since it is replaced with the previous list?
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71803>
The comment and the function name are opposite; and its logic obeys the comment description. In that case, we should remove "!" in the "!this.inFlightRequests.hasOutstandingRequests(node.id())" condition.
- Guozhang Wang
On April 2, 2014, 6:49 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19953/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 6:49 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1303
> https://issues.apache.org/jira/browse/KAFKA-1303
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Changes are described in the comment of selectMetadataDestination().
>
>
> 1. Added the logic to use bootstrap cluster if no node can be selected from the real cluster. 2. Fixed the issue that node is not selected randomally.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 855ae84f14aa91653b3fa855c2af40560323f42a
>
> Diff: https://reviews.apache.org/r/19953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>
Re: Review Request 19953: Patch for KAFKA-1303
Posted by Neha Narkhede <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19953/#review39550
-----------------------------------------------------------
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71956>
This logic is fairly involved. Let's add unit tests for each of the conditions mentioned here
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71954>
Could we just call this cluster instead of curCluster?
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java
<https://reviews.apache.org/r/19953/#comment71959>
random->any
- Neha Narkhede
On April 2, 2014, 6:49 p.m., Jun Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19953/
> -----------------------------------------------------------
>
> (Updated April 2, 2014, 6:49 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1303
> https://issues.apache.org/jira/browse/KAFKA-1303
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Changes are described in the comment of selectMetadataDestination().
>
>
> 1. Added the logic to use bootstrap cluster if no node can be selected from the real cluster. 2. Fixed the issue that node is not selected randomally.
>
>
> Diffs
> -----
>
> clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java 855ae84f14aa91653b3fa855c2af40560323f42a
>
> Diff: https://reviews.apache.org/r/19953/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jun Rao
>
>