[jira] [Commented] (CASSANDRA-8771) Remove commit log segment recycling

["Jonathan Ellis (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14313444#comment-14313444 ] 

Jonathan Ellis commented on CASSANDRA-8771:
-------------------------------------------

We can't recycle when CL archiving is active either, so that complexity doesn't even buy us anything for those users.

I vote we kill it.

> Remove commit log segment recycling
> -----------------------------------
>
>                 Key: CASSANDRA-8771
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8771
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Core
>            Reporter: Ariel Weisberg
>
> For discussion
> Commit log segment recycling introduces a lot of complexity in the existing code.
> CASSANDRA-8729 is a side effect of commit log segment recycling and addressing it will require memory management code and thread coordination for memory that the filesystem will no longer handle for us.
> There is some discussion about what storage configurations actually benefit from preallocated files. Fast random access devices like SSDs, or non-volatile write caches etc. make the distinction not that great. 
> I haven't measured any difference in throughput for bulk appending vs overwriting although it was pointed out that I didn't test with concurrent IO streams.
> What would it take to make removing commit log segment recycling acceptable? Maybe a benchmark on a spinning disk that measures the performance impact of preallocation when there are other IO streams?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)