You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/19 00:38:00 UTC
[GitHub] [pulsar] liangyepianzhou opened a new pull request #12881: Handle exception double
liangyepianzhou opened a new pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881
Fixes https://github.com/apache/pulsar/pull/12744
### Motivation
The exception here was handled twice, resulting in a null pointer exception.
And the position will be updated twice.
### Modifications
Keep the exceptionally() part and convert the whenComplete() into thenAccept().
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- [ ] `no-need-doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on a change in pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on a change in pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#discussion_r752816022
##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheImpl.java
##########
@@ -234,7 +228,11 @@ private void asyncReadEntry0(ReadHandle lh, PositionImpl position, final ReadEnt
} finally {
ledgerEntries.close();
}
- }, ml.getExecutor().chooseThread(ml.getName()));
Review comment:
Thank you for pointing out this problem, it may be better to use asynchronous operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#issuecomment-973682394
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#issuecomment-973649841
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Jason918 commented on a change in pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
Jason918 commented on a change in pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#discussion_r752810390
##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/EntryCacheImpl.java
##########
@@ -234,7 +228,11 @@ private void asyncReadEntry0(ReadHandle lh, PositionImpl position, final ReadEnt
} finally {
ledgerEntries.close();
}
- }, ml.getExecutor().chooseThread(ml.getName()));
Review comment:
What's the reason of removing this async thread executor? IMHO, it may cause some concurrent issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#issuecomment-973583791
@liangyepianzhou:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#issuecomment-973614704
@liangyepianzhou:Thanks for providing doc info!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#issuecomment-974297759
Good work @liangyepianzhou !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] liangyepianzhou commented on pull request #12881: Handle exception double
Posted by GitBox <gi...@apache.org>.
liangyepianzhou commented on pull request #12881:
URL: https://github.com/apache/pulsar/pull/12881#issuecomment-973639827
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org