[GitHub] [apisix] tokers commented on a diff in pull request #8824: fix: invalidate cache in core.request.add_haeder and fix some calls

["tokers (via GitHub)" <gi...@apache.org>]

tokers commented on code in PR #8824:
URL: https://github.com/apache/apisix/pull/8824#discussion_r1102188367


##########
apisix/plugins/proxy-rewrite.lua:
##########
@@ -311,18 +311,18 @@ do
         for i = 1, field_cnt, 2 do
             local val = core.utils.resolve_var(hdr_op.add[i + 1], ctx.var)
             local header = hdr_op.add[i]
-            core.request.add_header(header, val)
+            core.request.add_header(ctx, header, val)

Review Comment:
   We may add a case to ensure the warning message won't be generated anymore.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org