You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by bt...@apache.org on 2020/04/03 10:27:41 UTC
[james-project] 05/08: [Refactoring] avoid creating Arrays to call
varargs methods
This is an automated email from the ASF dual-hosted git repository.
btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit cc4467afef5ca0fa481bf3397712a0aecb6a3bfe
Author: Matthieu Baechler <ma...@apache.org>
AuthorDate: Wed Mar 25 12:07:01 2020 +0100
[Refactoring] avoid creating Arrays to call varargs methods
---
.../main/java/org/apache/james/transport/mailets/AbstractSign.java | 2 +-
.../org/apache/james/imap/api/message/response/StatusResponse.java | 6 +++---
.../org/apache/james/protocols/smtp/AbstractSMTPServerTest.java | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java b/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java
index e19cc89..99f60c8 100644
--- a/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java
+++ b/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java
@@ -259,7 +259,7 @@ public abstract class AbstractSign extends GenericMailet {
protected void initKeyHolder() throws Exception {
Constructor<?> keyHolderConstructor;
try {
- keyHolderConstructor = keyHolderClass.getConstructor(new Class[] {String.class, String.class, String.class, String.class, String.class});
+ keyHolderConstructor = keyHolderClass.getConstructor(String.class, String.class, String.class, String.class, String.class);
} catch (NoSuchMethodException nsme) {
throw new MessagingException("The needed constructor does not exist: "
+ keyHolderClass + "(String, String, String, String, String)");
diff --git a/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java
index 71eaf13..39ecc29 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/api/message/response/StatusResponse.java
@@ -161,21 +161,21 @@ public interface StatusResponse extends ImapResponseMessage {
String source = formatRanges(sourceRanges);
String target = formatRanges(targetRanges);
- return new ResponseCode("COPYUID", Arrays.asList(new String[] { source, target }), uidValidity.asLong(), false);
+ return new ResponseCode("COPYUID", Arrays.asList(source, target), uidValidity.asLong(), false);
}
/** RFC4551 <code>Conditional STORE</code> response code */
public static ResponseCode condStore(IdRange[] failedRanges) {
String failed = formatRanges(failedRanges);
- return new ResponseCode("MODIFIED", Arrays.asList(new String[] { failed}), 0, false);
+ return new ResponseCode("MODIFIED", Arrays.asList(failed), 0, false);
}
/** RFC4551 <code>Conditional STORE</code> response code */
public static ResponseCode condStore(UidRange[] failedRanges) {
String failed = formatRanges(failedRanges);
- return new ResponseCode("MODIFIED", Arrays.asList(new String[] { failed}), 0, false);
+ return new ResponseCode("MODIFIED", Arrays.asList(failed), 0, false);
}
private static String formatRanges(IdRange[] ranges) {
diff --git a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractSMTPServerTest.java b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractSMTPServerTest.java
index 19d084f..97203ec 100644
--- a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractSMTPServerTest.java
+++ b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/AbstractSMTPServerTest.java
@@ -731,7 +731,7 @@ public abstract class AbstractSMTPServerTest {
public void testNullSender() throws Exception {
ProtocolServer server = null;
try {
- server = createServer(createProtocol(new ProtocolHandler[0]));
+ server = createServer(createProtocol());
server.bind();
SMTPClient client = createClient();
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org