You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/13 11:32:32 UTC
[GitHub] [airflow] kaxil commented on a change in pull request #15820: Improve feedback message after installing or upgrading airflow with helm chart
kaxil commented on a change in pull request #15820:
URL: https://github.com/apache/airflow/pull/15820#discussion_r631743464
##########
File path: chart/templates/NOTES.txt
##########
@@ -16,12 +16,15 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/}}Thank you for installing Airflow!
+*/}}
+
+
Review comment:
```suggestion
```
##########
File path: chart/templates/NOTES.txt
##########
@@ -30,10 +33,36 @@ Flower dashboard: http{{ if .Values.ingress.flower.tls.enabled }}s{{ end }}
{{- else }}
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
-Airflow dashboard: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+ kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+
{{- if .Values.flower.enabled }}
{{- if or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")}}
Flower dashboard: kubectl port-forward svc/{{ .Release.Name }}-flower {{ .Values.ports.flowerUI }}:{{ .Values.ports.flowerUI }} --namespace {{ .Release.Namespace }}
{{- end }}
{{- end }}
{{- end }}
+
+Run this command to see the list of running pods:
+ kubectl get pods --namespace {{ .Release.Namespace }}
+
Review comment:
```suggestion
```
##########
File path: chart/templates/NOTES.txt
##########
@@ -16,12 +16,15 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/}}Thank you for installing Airflow!
+*/}}
+
+
+Thank you for installing Apache {{ title .Chart.Name }}!
Your release is named {{ .Release.Name }}.
-{{- if .Values.ingress.enabled }}
-You can now access your service(s) by following defined Ingress urls:
+{{ if .Values.ingress.enabled }}
+You can now access your dashboard(s) by following defined Ingress urls:
Review comment:
```suggestion
You can now access your service(s) by following defined Ingress urls:
```
`services` as Airflow Webserver is not a Dashboard
##########
File path: chart/templates/NOTES.txt
##########
@@ -30,10 +33,36 @@ Flower dashboard: http{{ if .Values.ingress.flower.tls.enabled }}s{{ end }}
{{- else }}
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
-Airflow dashboard: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+ kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+
{{- if .Values.flower.enabled }}
{{- if or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")}}
Flower dashboard: kubectl port-forward svc/{{ .Release.Name }}-flower {{ .Values.ports.flowerUI }}:{{ .Values.ports.flowerUI }} --namespace {{ .Release.Namespace }}
{{- end }}
{{- end }}
{{- end }}
+
+Run this command to see the list of running pods:
+ kubectl get pods --namespace {{ .Release.Namespace }}
+
+
+{{ if .Values.webserver.defaultUser.enabled}}
+Default Webserver (Airflow UI) Login credentials:
+ username: {{ .Values.webserver.defaultUser.username }}
+ password: {{ .Values.webserver.defaultUser.password }}
+ port: {{ .Values.ports.airflowUI }}
+
+{{ end }}
Review comment:
```suggestion
{{- end }}
```
##########
File path: chart/templates/NOTES.txt
##########
@@ -16,12 +16,15 @@ KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-*/}}Thank you for installing Airflow!
+*/}}
+
+
+Thank you for installing Apache {{ title .Chart.Name }}!
Your release is named {{ .Release.Name }}.
-{{- if .Values.ingress.enabled }}
-You can now access your service(s) by following defined Ingress urls:
+{{ if .Values.ingress.enabled }}
Review comment:
```suggestion
{{- if .Values.ingress.enabled }}
```
Otherwise it will leave a blank line
##########
File path: chart/templates/NOTES.txt
##########
@@ -30,10 +33,36 @@ Flower dashboard: http{{ if .Values.ingress.flower.tls.enabled }}s{{ end }}
{{- else }}
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
-Airflow dashboard: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+ kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+
{{- if .Values.flower.enabled }}
{{- if or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")}}
Flower dashboard: kubectl port-forward svc/{{ .Release.Name }}-flower {{ .Values.ports.flowerUI }}:{{ .Values.ports.flowerUI }} --namespace {{ .Release.Namespace }}
{{- end }}
{{- end }}
{{- end }}
+
+Run this command to see the list of running pods:
+ kubectl get pods --namespace {{ .Release.Namespace }}
+
+
+{{ if .Values.webserver.defaultUser.enabled}}
+Default Webserver (Airflow UI) Login credentials:
+ username: {{ .Values.webserver.defaultUser.username }}
+ password: {{ .Values.webserver.defaultUser.password }}
+ port: {{ .Values.ports.airflowUI }}
+
+{{ end }}
+
+{{- if .Values.postgresql.enabled }}
+Default Postgres connection credentials:
+ username: {{ .Values.data.metadataConnection.user }}
+ password: {{ .Values.data.metadataConnection.pass }}
+ port: {{ .Values.data.metadataConnection.port }}
+
+{{- end }}
+
+{{- if .Values.flower.enable }}
+FlowerUI running on:
+ port: {{ .Values.ports.flowerUI }}
+{{- end }}
Review comment:
This is covered on L40 though
##########
File path: chart/templates/NOTES.txt
##########
@@ -30,10 +33,36 @@ Flower dashboard: http{{ if .Values.ingress.flower.tls.enabled }}s{{ end }}
{{- else }}
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
-Airflow dashboard: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+ kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+
{{- if .Values.flower.enabled }}
{{- if or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")}}
Flower dashboard: kubectl port-forward svc/{{ .Release.Name }}-flower {{ .Values.ports.flowerUI }}:{{ .Values.ports.flowerUI }} --namespace {{ .Release.Namespace }}
{{- end }}
{{- end }}
{{- end }}
+
+Run this command to see the list of running pods:
+ kubectl get pods --namespace {{ .Release.Namespace }}
+
+
+{{ if .Values.webserver.defaultUser.enabled}}
Review comment:
```suggestion
{{- if .Values.webserver.defaultUser.enabled}}
```
##########
File path: chart/templates/NOTES.txt
##########
@@ -30,10 +33,36 @@ Flower dashboard: http{{ if .Values.ingress.flower.tls.enabled }}s{{ end }}
{{- else }}
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
-Airflow dashboard: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+ kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
Review comment:
```suggestion
Airflow Webserver: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
```
##########
File path: chart/templates/NOTES.txt
##########
@@ -30,10 +33,36 @@ Flower dashboard: http{{ if .Values.ingress.flower.tls.enabled }}s{{ end }}
{{- else }}
You can now access your dashboard(s) by executing the following command(s) and visiting the corresponding port at localhost in your browser:
-Airflow dashboard: kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+ kubectl port-forward svc/{{ .Release.Name }}-webserver {{ .Values.ports.airflowUI }}:{{ .Values.ports.airflowUI }} --namespace {{ .Release.Namespace }}
+
{{- if .Values.flower.enabled }}
{{- if or (eq .Values.executor "CeleryExecutor") (eq .Values.executor "CeleryKubernetesExecutor")}}
Flower dashboard: kubectl port-forward svc/{{ .Release.Name }}-flower {{ .Values.ports.flowerUI }}:{{ .Values.ports.flowerUI }} --namespace {{ .Release.Namespace }}
{{- end }}
{{- end }}
{{- end }}
+
+Run this command to see the list of running pods:
+ kubectl get pods --namespace {{ .Release.Namespace }}
+
Review comment:
I personally feel it is not that useful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org