[GitHub] [inlong] healchow commented on pull request #7171: [INLONG-5776][Manager] Add tenant param to InlongGroup that uses Pulsar

[GitBox <gi...@apache.org>]

healchow commented on PR #7171:
URL: https://github.com/apache/inlong/pull/7171#issuecomment-1374419380

   > This is a reasonable change, but it may lead to a configure failure for current SortStandalone and DataProxy. There are two important things to adapt this modification:
   > 
   > 1. A update manuscript from last version to the newest one,
   > 2. SortSandalone and DataProxy should change the way to acquire "tenant".
   
   Thanks for your review🎉
   
   As I considered compatibility with DataProxy and SortStandalone, **I did not add the default value for the tenant in the InlongPulsarRequest**, see the code:
   
   https://github.com/apache/inlong/blob/dea5e1fb9d9f9dad572b7a76e9e4e136b6376779/inlong-manager/manager-pojo/src/main/java/org/apache/inlong/manager/pojo/group/pulsar/InlongPulsarRequest.java#L39-L44
   
   That is to say, if you do not set the tenant value when creating or modifying InlongGroup, DataProxy and SortStandalone will read the tenant from the PulsarCluster when they obtain the tenant, because there is no tenant in InlongGroup.
   
   This way should be compatible with historical data. And finally, if you want to upgrade all historical data, you need to modify the request methods of DataProxy / SortStandalone and copy the tenant configuration from PulsarClusters to the related InlongGroups.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org