You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by arunmahadevan <gi...@git.apache.org> on 2018/08/08 18:56:35 UTC
[GitHub] storm pull request #2798: STORM-3184: Mask the plaintext passwords from the ...
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2798
STORM-3184: Mask the plaintext passwords from the logs
Introduce a `Password` config annotation and use it to mark configs that are
sensitive and mask the values while logging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/storm STORM-3184
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2798.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2798
----
commit fc942ee10d86649db9e9b8ce3dc0a04ea23439ce
Author: Arun Mahadevan <ar...@...>
Date: 2018-08-07T19:13:54Z
STORM-3184: Mask the plaintext passwords from the logs
Introduce a `Password` config annotation and use it to mark configs that are
sensitive and mask the values while logging.
----
---
[GitHub] storm pull request #2798: STORM-3184: Mask the plaintext passwords from the ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2798
---
[GitHub] storm issue #2798: STORM-3184: Mask the plaintext passwords from the logs
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
@HeartSaVioR heres the master port - https://github.com/apache/storm/pull/2801
I guess sooner we release 2.0 and stick to master branch for even minor feature development the better.
---
[GitHub] storm issue #2798: STORM-3184: Mask the plaintext passwords from the logs
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2798
ping @arunmahadevan
---
[GitHub] storm issue #2798: STORM-3184: Mask the plaintext passwords from the logs
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
ping @HeartSaVioR
---
[GitHub] storm issue #2798: STORM-3184: Mask the plaintext passwords from the logs
Posted by arunmahadevan <gi...@git.apache.org>.
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2798
@HeartSaVioR , i had a quick look and its not straightforward to port this patch to master. The Configs are now split into Config and DaemonConfig and quite a lot of refactoring has happened. I need to figure out the right place to put this so that the code can be shared across the storm-client and storm-server modules.
---
[GitHub] storm issue #2798: STORM-3184: Mask the plaintext passwords from the logs
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2798
@arunmahadevan Totally agreed. We should move onto Storm 2.0.0, and actually most of recent pull requests have been only applied to master branch.
---