You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/02/21 10:16:55 UTC
[GitHub] [iotdb] choubenson opened a new pull request #5100: [IOTDB-2582]Enable reading chunk by timestamp
choubenson opened a new pull request #5100:
URL: https://github.com/apache/iotdb/pull/5100
Currently, we use ChunkReaderByTimestamp by calling its contructor and then setting the currentTimestamp, which makes the class invalid and does not accelerate queries.
**To Reproduce**
Steps to reproduce the behavior:
Import org.apache.iotdb.tsfile.read.reader.chunk.ChunkReaderByTimestamp and its super class org.apache.iotdb.tsfile.read.reader.chunk.ChunkReader.
Read or build one Chunk with a few data
Construct a ChunkReader, a ChunkReaderByTimestamp, and set the currentTimestamp of the latter one with interface public void setCurrentTimestamp(long currentTimestamp)
Run with debugger and watch the member variable private List<IPageReader> pageReaderList of these two instances. They are always the same.
Or fetch data by while (reader.hasNextSatisfiedPage()) {BatchData batchData = reader.nextPageData()} and print all points. They are always the same, too.
**Solution**
Therefore, we remove the ChunkReaderByTimestamp , instead, we add a constructor in ChunkReader to implement reading chunk by timestamp, which is
public ChunkReader(Chunk chunk, Filter filter, long currentTimestamp)
So does AlignedChunkReaderByTimestamp.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls edited a comment on pull request #5100: [IOTDB-2582]Enable reading chunk by timestamp
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #5100:
URL: https://github.com/apache/iotdb/pull/5100#issuecomment-1046772288
[](https://coveralls.io/builds/46738590)
Coverage increased (+0.01%) to 67.824% when pulling **be05e65d10887283657f625a84bccbeccaf541a3 on choubenson:fixChunkReaderByTimestamp** into **aa9efee3905bc0ba78b6c61b1e9207daf99d0d19 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] coveralls commented on pull request #5100: [IOTDB-2582]Enable reading chunk by timestamp
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #5100:
URL: https://github.com/apache/iotdb/pull/5100#issuecomment-1046772288
[](https://coveralls.io/builds/46728860)
Coverage decreased (-0.01%) to 67.798% when pulling **43b18a090da9349e79a1b225417a1fa5c9d69940 on choubenson:fixChunkReaderByTimestamp** into **aa9efee3905bc0ba78b6c61b1e9207daf99d0d19 on apache:master**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #5100: [IOTDB-2582]Enable reading chunk by timestamp
Posted by GitBox <gi...@apache.org>.
HTHou merged pull request #5100:
URL: https://github.com/apache/iotdb/pull/5100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org