You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/11 09:33:22 UTC
[GitHub] [spark] wangyum opened a new pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
wangyum opened a new pull request #30331:
URL: https://github.com/apache/spark/pull/30331
### What changes were proposed in this pull request?
This pr removes `EXCEPT`, `INTERSECT`, `MINUS` and `UNION` from strictNonReserved.
### Why are the changes needed?
1. This is a regression since Spark 3.0.
2. `EXCEPT`, `INTERSECT` and `UNION` are all reserved, Please see https://www.postgresql.org/docs/12/sql-keywords-appendix.html for more details.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725383256
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35533/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725392893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-739526858
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725351113
**[Test build #130928 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130928/testReport)** for PR 30331 at commit [`15759d9`](https://github.com/apache/spark/commit/15759d996304b8f2f65ad8c4d5f881976a317bb0).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725351293
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-742995297
@wangyum, why did you close? just curious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725314745
**[Test build #130928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130928/testReport)** for PR 30331 at commit [`15759d9`](https://github.com/apache/spark/commit/15759d996304b8f2f65ad8c4d5f881976a317bb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #30331:
URL: https://github.com/apache/spark/pull/30331
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-739524751
**[Test build #132296 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132296/testReport)** for PR 30331 at commit [`15759d9`](https://github.com/apache/spark/commit/15759d996304b8f2f65ad8c4d5f881976a317bb0).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725351303
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/130928/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725392893
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-739512341
**[Test build #132296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132296/testReport)** for PR 30331 at commit [`15759d9`](https://github.com/apache/spark/commit/15759d996304b8f2f65ad8c4d5f881976a317bb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-739526858
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132296/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-739512341
**[Test build #132296 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132296/testReport)** for PR 30331 at commit [`15759d9`](https://github.com/apache/spark/commit/15759d996304b8f2f65ad8c4d5f881976a317bb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725392875
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35533/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725314745
**[Test build #130928 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/130928/testReport)** for PR 30331 at commit [`15759d9`](https://github.com/apache/spark/commit/15759d996304b8f2f65ad8c4d5f881976a317bb0).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30331: [SPARK-33128][SQL] Remove EXCEPT, INTERSECT, MINUS, UNION from strictNonReserved
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30331:
URL: https://github.com/apache/spark/pull/30331#issuecomment-725351293
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org