You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/10 03:28:11 UTC

[GitHub] [kafka] vcrfxia commented on pull request #10091: KAFKA-9524: increase retention time for window and grace periods longer than one day

vcrfxia commented on pull request #10091:
URL: https://github.com/apache/kafka/pull/10091#issuecomment-776412900


   Rather than having the `grace(...)` method update `maintainDurationMs`, would it be better to update `maintainMs()` to return `Math.max(maintainDurationMs, sizeMs + graceMs)` rather than `Math.max(maintainDurationMs, sizeMs)`?
   https://github.com/apache/kafka/blob/7583e14fb20b34a044d92dcf6b078456bc4f6903/streams/src/main/java/org/apache/kafka/streams/kstream/TimeWindows.java#L247-L249
   
   This feels more consistent with the fact that `maintainDurationMs` currently not only does not reflect grace period, but also does not reflect window size.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org