[GitHub] [skywalking] xiaozaiyuji commented on a diff in pull request #10557: modify the service query and query by group and layer and modify the elasticsearch scroll queryMaxSize

["xiaozaiyuji (via GitHub)" <gi...@apache.org>]

xiaozaiyuji commented on code in PR #10557:
URL: https://github.com/apache/skywalking/pull/10557#discussion_r1141012243


##########
oap-server/server-query-plugin/query-graphql-plugin/src/main/java/org/apache/skywalking/oap/query/graphql/resolver/MetadataQueryV2.java:
##########
@@ -67,6 +67,10 @@ public List<Service> listServices(final String layer) throws IOException {
         return getMetadataQueryService().listServices(layer, null);
     }
 
+    public List<Service> listGroupServices(final String layer, final String group) throws IOException {

Review Comment:
   > And what is the reason of ElasticSearch change? A pull request must include the explanation. One pull request is about one thing. Please be clear about the change, otherwise, we don't know what do you mean, and how could we follow?
   
   Sorry this the first to pull request for open source ,I explain will explain it carefully.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org