You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2016/04/27 13:55:58 UTC
Review Request 46736: Added authorization description to quota
endpoint help.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
-----------------------------------------------------------
Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
Repository: mesos
Description
-------
see summary.
Diffs
-----
docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
Diff: https://reviews.apache.org/r/46736/diff/
Testing
-------
make check (OSX) and re-generated endpoint documentation.
Thanks,
Joerg Schad
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review130798
-----------------------------------------------------------
Bad patch!
Reviews applied: [46736, 46735]
Failed command: ./support/apply-review.sh -n -r 46735
Error:
2016-04-27 15:16:33 URL:https://reviews.apache.org/r/46735/diff/raw/ [3099/3099] -> "46735.patch" [1]
Total errors found: 0
Checking 4 files
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
src/master/http.cpp
libprocess:
3rdparty/libprocess/include/process/help.hpp
3rdparty/libprocess/src/help.cpp
3rdparty/libprocess/src/logging.cpp
Full log: https://builds.apache.org/job/mesos-reviewbot/12761/console
- Mesos ReviewBot
On April 27, 2016, 3:05 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 3:05 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Alexander Rojas <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review130892
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rojas
On April 27, 2016, 5:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 5:17 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review130800
-----------------------------------------------------------
Ship it!
Ship It!
- haosdent huang
On April 27, 2016, 3:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 3:17 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review131179
-----------------------------------------------------------
Patch looks great!
Reviews applied: [46735, 46736]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On April 29, 2016, 2:26 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 2:26 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review131100
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On April 29, 2016, 2:26 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 2:26 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
-----------------------------------------------------------
(Updated April 29, 2016, 2:26 p.m.)
Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
Diff: https://reviews.apache.org/r/46736/diff/
Testing
-------
make check (OSX) and re-generated endpoint documentation.
Thanks,
Joerg Schad
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review131089
-----------------------------------------------------------
docs/endpoints/master/quota.md (line 29)
<https://reviews.apache.org/r/46736/#comment195034>
I would rephrase this. As written, it sounds to me like the _endpoint_ is what grants "certain principals" the ability "to set quota for certain roles". I would instead say something like: "Using this endpoint to set a quota for a certain role requires that the current principal has the `set_quotas` ACL for that role. Similarly, using this endpoint to remove a quota..."
- Neil Conway
On April 29, 2016, 9:40 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 29, 2016, 9:40 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
-----------------------------------------------------------
(Updated April 29, 2016, 9:40 a.m.)
Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
Diff: https://reviews.apache.org/r/46736/diff/
Testing
-------
make check (OSX) and re-generated endpoint documentation.
Thanks,
Joerg Schad
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
-----------------------------------------------------------
(Updated April 27, 2016, 3:17 p.m.)
Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
Diff: https://reviews.apache.org/r/46736/diff/
Testing
-------
make check (OSX) and re-generated endpoint documentation.
Thanks,
Joerg Schad
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/
-----------------------------------------------------------
(Updated April 27, 2016, 3:05 p.m.)
Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
Repository: mesos
Description
-------
see summary.
Diffs (updated)
-----
docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
Diff: https://reviews.apache.org/r/46736/diff/
Testing
-------
make check (OSX) and re-generated endpoint documentation.
Thanks,
Joerg Schad
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review130776
-----------------------------------------------------------
Bad patch!
Reviews applied: [46736, 46735]
Failed command: ./support/apply-review.sh -n -r 46735
Error:
2016-04-27 13:14:33 URL:https://reviews.apache.org/r/46735/diff/raw/ [3099/3099] -> "46735.patch" [1]
Total errors found: 0
Checking 4 files
ERROR: Commit spanning multiple projects.
Please use separate commits for mesos, libprocess and stout.
Paths grouped by project:
mesos:
src/master/http.cpp
libprocess:
3rdparty/libprocess/include/process/help.hpp
3rdparty/libprocess/src/help.cpp
3rdparty/libprocess/src/logging.cpp
Full log: https://builds.apache.org/job/mesos-reviewbot/12759/console
- Mesos ReviewBot
On April 27, 2016, 11:55 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 11:55 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Alexander Rukletsov <ru...@gmail.com>.
> On April 27, 2016, 1:17 p.m., Alexander Rukletsov wrote:
> > src/master/http.cpp, lines 1272-1274
> > <https://reviews.apache.org/r/46736/diff/1/?file=1363210#file1363210line1272>
> >
> > Any reason you wrap it differently from other entries?
It also looks like we indent by spaces, can you make it consistent?
- Alexander
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review130777
-----------------------------------------------------------
On April 27, 2016, 3:17 p.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 3:17 p.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>
Re: Review Request 46736: Added authorization description to quota
endpoint help.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46736/#review130777
-----------------------------------------------------------
Fix it, then Ship it!
docs/endpoints/master/quota.md (line 29)
<https://reviews.apache.org/r/46736/#comment194668>
Two spaces got lost: one between "certain roles" and one between the sentences.
src/master/http.cpp (lines 1272 - 1274)
<https://reviews.apache.org/r/46736/#comment194669>
Any reason you wrap it differently from other entries?
- Alexander Rukletsov
On April 27, 2016, 11:55 a.m., Joerg Schad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46736/
> -----------------------------------------------------------
>
> (Updated April 27, 2016, 11:55 a.m.)
>
>
> Review request for mesos, Adam B, Alexander Rukletsov, and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> docs/endpoints/master/quota.md 682370f8d7ee44aa858913ba4cee62cb8259e0e6
> src/master/http.cpp 4f489fb9e5bc77b839cc4a44d7ec36af06f73e4a
>
> Diff: https://reviews.apache.org/r/46736/diff/
>
>
> Testing
> -------
>
> make check (OSX) and re-generated endpoint documentation.
>
>
> Thanks,
>
> Joerg Schad
>
>