You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Mike Jumper <mi...@guac-dev.org> on 2016/05/18 16:51:48 UTC
GitHub vs. the mailing lists
Hello all,
Does anyone here have any experience with using GitHub pull requests in a
code review workflow which leverages a podling's mailing lists?
Since things have only happened if on the mailing lists, it'd be nice if PR
activity could truly "happen" as well.
I'm specifically interested in configuring the ASF GitHub mirrors to
automatically send pull request notifications (comments, status changes,
etc.) to the commits list, but alternative methods are definitely welcome
if this is not actually possible.
Thanks,
- Mike
Re: GitHub vs. the mailing lists
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Sterling,
FYI, at Beam (again ;)), we discussed with Infra to have a mergebot
account and automatically trigger PR merging.
Regards
JB
On 05/18/2016 06:56 PM, Sterling Hughes wrote:
> Hi Mike,
>
> On 5/18/16 11:51 AM, Mike Jumper wrote:
>> Hello all,
>>
>> Does anyone here have any experience with using GitHub pull requests in a
>> code review workflow which leverages a podling's mailing lists?
>>
>> Since things have only happened if on the mailing lists, it'd be nice
>> if PR
>> activity could truly "happen" as well.
>
> We take all our contributions via GH pull requests on Mynewt. Generally,
> the rule is that if there is a significant (whatever you want to call
> significant) change, that the discussion happen on the mailing list. If
> you just want to comment on small things in PRs, just do it on GH.
>
>>
>> I'm specifically interested in configuring the ASF GitHub mirrors to
>> automatically send pull request notifications (comments, status changes,
>> etc.) to the commits list, but alternative methods are definitely welcome
>> if this is not actually possible.
>>
>
> That would be great, if you can configure it that way, let us know.
>
> Right now, we have to manually merge the pull request via Git -- there
> is no way to accept it on GH and have it mirror back to the ASF repo.
> This is not ideal, but its not really a big deal either. When we do the
> commits to the ASF repo, it mirrors back to GH, and automatically closes
> the PR (and all of this goes to the commits@) email list.
>
> https://help.github.com/articles/closing-issues-via-commit-messages/
>
> Cheers,
>
> Sterling
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: GitHub vs. the mailing lists
Posted by Sterling Hughes <st...@apache.org>.
Hi Mike,
On 5/18/16 11:51 AM, Mike Jumper wrote:
> Hello all,
>
> Does anyone here have any experience with using GitHub pull requests in a
> code review workflow which leverages a podling's mailing lists?
>
> Since things have only happened if on the mailing lists, it'd be nice if PR
> activity could truly "happen" as well.
We take all our contributions via GH pull requests on Mynewt.
Generally, the rule is that if there is a significant (whatever you want
to call significant) change, that the discussion happen on the mailing
list. If you just want to comment on small things in PRs, just do it on GH.
>
> I'm specifically interested in configuring the ASF GitHub mirrors to
> automatically send pull request notifications (comments, status changes,
> etc.) to the commits list, but alternative methods are definitely welcome
> if this is not actually possible.
>
That would be great, if you can configure it that way, let us know.
Right now, we have to manually merge the pull request via Git -- there
is no way to accept it on GH and have it mirror back to the ASF repo.
This is not ideal, but its not really a big deal either. When we do the
commits to the ASF repo, it mirrors back to GH, and automatically closes
the PR (and all of this goes to the commits@) email list.
https://help.github.com/articles/closing-issues-via-commit-messages/
Cheers,
Sterling
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: GitHub vs. the mailing lists
Posted by Sterling Hughes <st...@apache.org>.
Hi Mike,
On 5/18/16 11:51 AM, Mike Jumper wrote:
> Hello all,
>
> Does anyone here have any experience with using GitHub pull requests in a
> code review workflow which leverages a podling's mailing lists?
>
> Since things have only happened if on the mailing lists, it'd be nice if PR
> activity could truly "happen" as well.
We take all our contributions via GH pull requests on Mynewt.
Generally, the rule is that if there is a significant (whatever you want
to call significant) change, that the discussion happen on the mailing
list. If you just want to comment on small things in PRs, just do it on GH.
>
> I'm specifically interested in configuring the ASF GitHub mirrors to
> automatically send pull request notifications (comments, status changes,
> etc.) to the commits list, but alternative methods are definitely welcome
> if this is not actually possible.
>
That would be great, if you can configure it that way, let us know.
Right now, we have to manually merge the pull request via Git -- there
is no way to accept it on GH and have it mirror back to the ASF repo.
This is not ideal, but its not really a big deal either. When we do the
commits to the ASF repo, it mirrors back to GH, and automatically closes
the PR (and all of this goes to the commits@) email list.
https://help.github.com/articles/closing-issues-via-commit-messages/
Cheers,
Sterling
Re: GitHub vs. the mailing lists
Posted by Luciano Resende <lu...@gmail.com>.
On Wed, May 18, 2016 at 1:59 PM, Christopher <ct...@apache.org> wrote:
> On Wed, May 18, 2016 at 12:54 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
> > Hi Mike,
> >
> > it's what we are doing at Beam.
> >
> > A PR submission result:
> > - to a mail on the mailing list
> > - to a comment in Jira (if the PR contains commit with issue ID).
> >
> >
> The GitHub integration is very useful, as it tracks the GitHub PR activity
> on the mailing list, and optionally, JIRA (if an issue is referenced).
>
> For the JIRA integration, we recently added a few new options [1]:
>
> (default) - add link to PR on JIRA and comment on the JIRA
> "nofollow" - no JIRA integration (mailing only)
> "linkonly" - add link to PR on JIRA
> "worklog" - add link to PR on JIRA, but use worklog instead of comment
>
> The "worklog" is my preferred option because it reduces mailing list spam
> if JIRA is also configured to send email notifications for comments.
>
> [1]: https://issues.apache.org/jira/browse/INFRA-11675
>
I have seen multiple projects, having multiple different configuration,
probably based on the 4 items mentioned above. I would suggest we have one
recommended way where we would see more uniformity, and this recommended
way might suggest that some of these notifications are actually sent to
different lists (e.g. Spark actually has a review list where some of these
notification are sent https://www.mail-archive.com/reviews@spark.apache.org/,
Zeppelin track reviews as JIRA comments, etc), but would give us a central
place to track some of these technical discussions, rather then having to
go following the path from mailing list, to jira, to github, etc....
Thanks
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: GitHub vs. the mailing lists
Posted by Luciano Resende <lu...@gmail.com>.
On Wed, May 18, 2016 at 1:59 PM, Christopher <ct...@apache.org> wrote:
> On Wed, May 18, 2016 at 12:54 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
> wrote:
>
> > Hi Mike,
> >
> > it's what we are doing at Beam.
> >
> > A PR submission result:
> > - to a mail on the mailing list
> > - to a comment in Jira (if the PR contains commit with issue ID).
> >
> >
> The GitHub integration is very useful, as it tracks the GitHub PR activity
> on the mailing list, and optionally, JIRA (if an issue is referenced).
>
> For the JIRA integration, we recently added a few new options [1]:
>
> (default) - add link to PR on JIRA and comment on the JIRA
> "nofollow" - no JIRA integration (mailing only)
> "linkonly" - add link to PR on JIRA
> "worklog" - add link to PR on JIRA, but use worklog instead of comment
>
> The "worklog" is my preferred option because it reduces mailing list spam
> if JIRA is also configured to send email notifications for comments.
>
> [1]: https://issues.apache.org/jira/browse/INFRA-11675
>
I have seen multiple projects, having multiple different configuration,
probably based on the 4 items mentioned above. I would suggest we have one
recommended way where we would see more uniformity, and this recommended
way might suggest that some of these notifications are actually sent to
different lists (e.g. Spark actually has a review list where some of these
notification are sent https://www.mail-archive.com/reviews@spark.apache.org/,
Zeppelin track reviews as JIRA comments, etc), but would give us a central
place to track some of these technical discussions, rather then having to
go following the path from mailing list, to jira, to github, etc....
Thanks
--
Luciano Resende
http://twitter.com/lresende1975
http://lresende.blogspot.com/
Re: GitHub vs. the mailing lists
Posted by Christopher <ct...@apache.org>.
On Wed, May 18, 2016 at 12:54 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> Hi Mike,
>
> it's what we are doing at Beam.
>
> A PR submission result:
> - to a mail on the mailing list
> - to a comment in Jira (if the PR contains commit with issue ID).
>
>
The GitHub integration is very useful, as it tracks the GitHub PR activity
on the mailing list, and optionally, JIRA (if an issue is referenced).
For the JIRA integration, we recently added a few new options [1]:
(default) - add link to PR on JIRA and comment on the JIRA
"nofollow" - no JIRA integration (mailing only)
"linkonly" - add link to PR on JIRA
"worklog" - add link to PR on JIRA, but use worklog instead of comment
The "worklog" is my preferred option because it reduces mailing list spam
if JIRA is also configured to send email notifications for comments.
[1]: https://issues.apache.org/jira/browse/INFRA-11675
Re: GitHub vs. the mailing lists
Posted by Daniel Gruno <hu...@apache.org>.
On 05/18/2016 07:00 PM, Mike Jumper wrote:
> On May 18, 2016 9:54 AM, "Jean-Baptiste Onofr�" <jb...@nanthrax.net> wrote:
>>
>> Hi Mike,
>>
>> it's what we are doing at Beam.
>>
>> A PR submission result:
>> - to a mail on the mailing list
>> - to a comment in Jira (if the PR contains commit with issue ID).
>>
>
> How have you achieved this?
>
> For Guacamole, we're seeing emails for the merge of a PR only (due no doubt
> to hooks in the ASF git repos). Comments on a PR, etc. will not find their
> way to the list.
>
File a ticket with Infra to have the github integration set up.
Do note that Infra currently has a substantial backlog of issues, so it
may take a while to get things done.
With regards,
Daniel.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
RE: GitHub vs. the mailing lists
Posted by Mike Jumper <mi...@guac-dev.org>.
On May 18, 2016 10:06 AM, "Steve Varnau" <st...@esgyn.com> wrote:
>
> Infra can configure the github to mailing list & github to JIRA for you.
>
> In trafodion, we have all github PR and comments going to a codereview
mail
> list
> http://mail-archives.apache.org/mod_mbox/incubator-trafodion-codereview/
> So there is a catch-all, even if the PR title is not in the correct format
> to mirror into Jira. (And for those that prefer email notice versus
> following on GH or Jira.)
>
Beautiful. Thanks, Steve.
RE: GitHub vs. the mailing lists
Posted by Mike Jumper <mi...@guac-dev.org>.
On May 18, 2016 10:06 AM, "Steve Varnau" <st...@esgyn.com> wrote:
>
> Infra can configure the github to mailing list & github to JIRA for you.
>
> In trafodion, we have all github PR and comments going to a codereview
mail
> list
> http://mail-archives.apache.org/mod_mbox/incubator-trafodion-codereview/
> So there is a catch-all, even if the PR title is not in the correct format
> to mirror into Jira. (And for those that prefer email notice versus
> following on GH or Jira.)
>
Beautiful. Thanks, Steve.
RE: GitHub vs. the mailing lists
Posted by Steve Varnau <st...@esgyn.com>.
Infra can configure the github to mailing list & github to JIRA for you.
In trafodion, we have all github PR and comments going to a codereview mail
list
http://mail-archives.apache.org/mod_mbox/incubator-trafodion-codereview/
So there is a catch-all, even if the PR title is not in the correct format
to mirror into Jira. (And for those that prefer email notice versus
following on GH or Jira.)
--Steve
> -----Original Message-----
> From: Mike Jumper [mailto:mike.jumper@guac-dev.org]
> Sent: Wednesday, May 18, 2016 10:00 AM
> To: general@incubator.apache.org
> Cc: dev@guacamole.incubator.apache.org
> Subject: Re: GitHub vs. the mailing lists
>
> On May 18, 2016 9:54 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
> >
> > Hi Mike,
> >
> > it's what we are doing at Beam.
> >
> > A PR submission result:
> > - to a mail on the mailing list
> > - to a comment in Jira (if the PR contains commit with issue ID).
> >
>
> How have you achieved this?
>
> For Guacamole, we're seeing emails for the merge of a PR only (due no
> doubt
> to hooks in the ASF git repos). Comments on a PR, etc. will not find their
> way to the list.
RE: GitHub vs. the mailing lists
Posted by Steve Varnau <st...@esgyn.com>.
Infra can configure the github to mailing list & github to JIRA for you.
In trafodion, we have all github PR and comments going to a codereview mail
list
http://mail-archives.apache.org/mod_mbox/incubator-trafodion-codereview/
So there is a catch-all, even if the PR title is not in the correct format
to mirror into Jira. (And for those that prefer email notice versus
following on GH or Jira.)
--Steve
> -----Original Message-----
> From: Mike Jumper [mailto:mike.jumper@guac-dev.org]
> Sent: Wednesday, May 18, 2016 10:00 AM
> To: general@incubator.apache.org
> Cc: dev@guacamole.incubator.apache.org
> Subject: Re: GitHub vs. the mailing lists
>
> On May 18, 2016 9:54 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
> >
> > Hi Mike,
> >
> > it's what we are doing at Beam.
> >
> > A PR submission result:
> > - to a mail on the mailing list
> > - to a comment in Jira (if the PR contains commit with issue ID).
> >
>
> How have you achieved this?
>
> For Guacamole, we're seeing emails for the merge of a PR only (due no
> doubt
> to hooks in the ASF git repos). Comments on a PR, etc. will not find their
> way to the list.
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: GitHub vs. the mailing lists
Posted by Mike Jumper <mi...@guac-dev.org>.
On May 18, 2016 9:54 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
>
> Hi Mike,
>
> it's what we are doing at Beam.
>
> A PR submission result:
> - to a mail on the mailing list
> - to a comment in Jira (if the PR contains commit with issue ID).
>
How have you achieved this?
For Guacamole, we're seeing emails for the merge of a PR only (due no doubt
to hooks in the ASF git repos). Comments on a PR, etc. will not find their
way to the list.
Re: GitHub vs. the mailing lists
Posted by Christopher <ct...@apache.org>.
On Wed, May 18, 2016 at 12:54 PM Jean-Baptiste Onofré <jb...@nanthrax.net>
wrote:
> Hi Mike,
>
> it's what we are doing at Beam.
>
> A PR submission result:
> - to a mail on the mailing list
> - to a comment in Jira (if the PR contains commit with issue ID).
>
>
The GitHub integration is very useful, as it tracks the GitHub PR activity
on the mailing list, and optionally, JIRA (if an issue is referenced).
For the JIRA integration, we recently added a few new options [1]:
(default) - add link to PR on JIRA and comment on the JIRA
"nofollow" - no JIRA integration (mailing only)
"linkonly" - add link to PR on JIRA
"worklog" - add link to PR on JIRA, but use worklog instead of comment
The "worklog" is my preferred option because it reduces mailing list spam
if JIRA is also configured to send email notifications for comments.
[1]: https://issues.apache.org/jira/browse/INFRA-11675
Re: GitHub vs. the mailing lists
Posted by Mike Jumper <mi...@guac-dev.org>.
On May 18, 2016 9:54 AM, "Jean-Baptiste Onofré" <jb...@nanthrax.net> wrote:
>
> Hi Mike,
>
> it's what we are doing at Beam.
>
> A PR submission result:
> - to a mail on the mailing list
> - to a comment in Jira (if the PR contains commit with issue ID).
>
How have you achieved this?
For Guacamole, we're seeing emails for the merge of a PR only (due no doubt
to hooks in the ASF git repos). Comments on a PR, etc. will not find their
way to the list.
Re: GitHub vs. the mailing lists
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Mike,
it's what we are doing at Beam.
A PR submission result:
- to a mail on the mailing list
- to a comment in Jira (if the PR contains commit with issue ID).
Regards
JB
On 05/18/2016 06:51 PM, Mike Jumper wrote:
> Hello all,
>
> Does anyone here have any experience with using GitHub pull requests in a
> code review workflow which leverages a podling's mailing lists?
>
> Since things have only happened if on the mailing lists, it'd be nice if PR
> activity could truly "happen" as well.
>
> I'm specifically interested in configuring the ASF GitHub mirrors to
> automatically send pull request notifications (comments, status changes,
> etc.) to the commits list, but alternative methods are definitely welcome
> if this is not actually possible.
>
> Thanks,
>
> - Mike
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: GitHub vs. the mailing lists
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Mike,
it's what we are doing at Beam.
A PR submission result:
- to a mail on the mailing list
- to a comment in Jira (if the PR contains commit with issue ID).
Regards
JB
On 05/18/2016 06:51 PM, Mike Jumper wrote:
> Hello all,
>
> Does anyone here have any experience with using GitHub pull requests in a
> code review workflow which leverages a podling's mailing lists?
>
> Since things have only happened if on the mailing lists, it'd be nice if PR
> activity could truly "happen" as well.
>
> I'm specifically interested in configuring the ASF GitHub mirrors to
> automatically send pull request notifications (comments, status changes,
> etc.) to the commits list, but alternative methods are definitely welcome
> if this is not actually possible.
>
> Thanks,
>
> - Mike
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
Re: GitHub vs. the mailing lists
Posted by Jean-Baptiste Onofré <jb...@nanthrax.net>.
Hi Mike,
it's what we are doing at Beam.
A PR submission result:
- to a mail on the mailing list
- to a comment in Jira (if the PR contains commit with issue ID).
Regards
JB
On 05/18/2016 06:51 PM, Mike Jumper wrote:
> Hello all,
>
> Does anyone here have any experience with using GitHub pull requests in a
> code review workflow which leverages a podling's mailing lists?
>
> Since things have only happened if on the mailing lists, it'd be nice if PR
> activity could truly "happen" as well.
>
> I'm specifically interested in configuring the ASF GitHub mirrors to
> automatically send pull request notifications (comments, status changes,
> etc.) to the commits list, but alternative methods are definitely welcome
> if this is not actually possible.
>
> Thanks,
>
> - Mike
>
--
Jean-Baptiste Onofr�
jbonofre@apache.org
http://blog.nanthrax.net
Talend - http://www.talend.com
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org