You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/02/18 05:34:13 UTC
Review Request 43697: CMake:[1/3] Move Stout configuration to its own
file.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/
-----------------------------------------------------------
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703
Repository: mesos
Description
-------
CMake:[1/3] Move Stout configuration to its own file.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739
Diff: https://reviews.apache.org/r/43697/diff/
Testing
-------
Thanks,
Alex Clemmer
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its
own file.
Posted by Alex Naparu <al...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review119948
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Naparu
On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43697/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:49 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/3] Move Stout configuration to its own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739
>
> Diff: https://reviews.apache.org/r/43697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its
own file.
Posted by Yi Sun <yi...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review119656
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake (line 105)
<https://reviews.apache.org/r/43697/#comment180997>
This seems like new. I suppose this is now needed.
- Yi Sun
On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43697/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:49 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/3] Move Stout configuration to its own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739
>
> Diff: https://reviews.apache.org/r/43697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its
own file.
Posted by Yi Sun <yi...@hotmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review119657
-----------------------------------------------------------
Ship it!
Ship It!
- Yi Sun
On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43697/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:49 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/3] Move Stout configuration to its own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739
>
> Diff: https://reviews.apache.org/r/43697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its
own file.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/#review121347
-----------------------------------------------------------
Fix it, then Ship it!
3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake (line 49)
<https://reviews.apache.org/r/43697/#comment183028>
extra period.
- Joris Van Remoortere
On Feb. 18, 2016, 5:49 a.m., Alex Clemmer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43697/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2016, 5:49 a.m.)
>
>
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
>
>
> Bugs: MESOS-4703
> https://issues.apache.org/jira/browse/MESOS-4703
>
>
> Repository: mesos
>
>
> Description
> -------
>
> CMake:[1/3] Move Stout configuration to its own file.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
> 3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739
>
> Diff: https://reviews.apache.org/r/43697/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Alex Clemmer
>
>
Re: Review Request 43697: CMake:[1/3] Move Stout configuration to its
own file.
Posted by Alex Clemmer <cl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43697/
-----------------------------------------------------------
(Updated Feb. 18, 2016, 5:49 a.m.)
Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
Bugs: MESOS-4703
https://issues.apache.org/jira/browse/MESOS-4703
Repository: mesos
Description
-------
CMake:[1/3] Move Stout configuration to its own file.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/cmake/StoutConfigure.cmake PRE-CREATION
3rdparty/libprocess/3rdparty/stout/cmake/StoutTestsConfigure.cmake a27cb98fa45cbd135ebfeca65e215fb3ff054739
Diff: https://reviews.apache.org/r/43697/diff/
Testing
-------
Thanks,
Alex Clemmer