You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2017/09/23 08:24:08 UTC
svn commit: r1809375 -
/ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
Author: jleroux
Date: Sat Sep 23 08:24:08 2017
New Revision: 1809375
URL: http://svn.apache.org/viewvc?rev=1809375&view=rev
Log:
Implemented: Missing foreign key constraint for fields userLoginId &
userPrefGroupTypeId in UserPreference entity
UserPreference.userLoginId is related to UserLogin.userLoginId.
UserPreference.userPrefGroupTypeId is related to
UserPrefGroupType.userPrefGroupTypeId.
(OFBIZ-9678)
Thanks: Aditya
Modified:
ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
Modified: ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml?rev=1809375&r1=1809374&r2=1809375&view=diff
==============================================================================
--- ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml (original)
+++ ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml Sat Sep 23 08:24:08 2017
@@ -639,6 +639,12 @@ under the License.
<field name="userPrefDataType" type="id-long"><description>The java data type of this preference (empty = java.lang.String)</description></field>
<prim-key field="userLoginId"/>
<prim-key field="userPrefTypeId"/>
+ <relation type="one" fk-name="UP_User_Login" rel-entity-name="UserLogin">
+ <key-map field-name="userLoginId"/>
+ </relation>
+ <relation type="one" fk-name="UP_User_Group_Type" rel-entity-name="UserPrefGroupType">
+ <key-map field-name="userPrefGroupTypeId"/>
+ </relation>
</entity>
<entity entity-name="UserPrefGroupType"
Re: svn commit: r1809375 - /ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
Posted by Aditya Sharma <ad...@hotwaxsystems.com>.
Hi Deepak,
Good observation. I missed on that. I will keep that in mind & update the
patch.
Thanks and Regards,
*Aditya Sharma* | Enterprise Software Engineer
HotWax Systems <http://www.hotwaxsystems.com/>
<https://www.linkedin.com/in/aditya-sharma-78291810a/>
On Sat, Sep 23, 2017 at 2:06 PM, Deepak Dixit <deepak.dixit@hotwaxsystems.co
m> wrote:
> Hi Aditya,
>
> It would be good if we use upper case for fk-name, as its constraints and
> across the application we are using fk-name as upper case.
>
> Thanks & Regards
> --
> Deepak Dixit
> www.hotwaxsystems.com
> www.hotwax.co
>
> On Sat, Sep 23, 2017 at 1:54 PM, <jl...@apache.org> wrote:
>
> > Author: jleroux
> > Date: Sat Sep 23 08:24:08 2017
> > New Revision: 1809375
> >
> > URL: http://svn.apache.org/viewvc?rev=1809375&view=rev
> > Log:
> > Implemented: Missing foreign key constraint for fields userLoginId &
> > userPrefGroupTypeId in UserPreference entity
> >
> > UserPreference.userLoginId is related to UserLogin.userLoginId.
> > UserPreference.userPrefGroupTypeId is related to
> > UserPrefGroupType.userPrefGroupTypeId.
> >
> > (OFBIZ-9678)
> >
> >
> > Thanks: Aditya
> >
> > Modified:
> > ofbiz/ofbiz-framework/trunk/framework/common/entitydef/enti
> tymodel.xml
> >
> > Modified: ofbiz/ofbiz-framework/trunk/framework/common/entitydef/
> > entitymodel.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> > framework/common/entitydef/entitymodel.xml?rev=1809375&
> > r1=1809374&r2=1809375&view=diff
> > ============================================================
> > ==================
> > --- ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entit
> ymodel.xml
> > (original)
> > +++ ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entit
> ymodel.xml
> > Sat Sep 23 08:24:08 2017
> > @@ -639,6 +639,12 @@ under the License.
> > <field name="userPrefDataType" type="id-long"><description>The
> > java data type of this preference (empty = java.lang.String)</
> > description></field>
> > <prim-key field="userLoginId"/>
> > <prim-key field="userPrefTypeId"/>
> > + <relation type="one" fk-name="UP_User_Login"
> > rel-entity-name="UserLogin">
> > + <key-map field-name="userLoginId"/>
> > + </relation>
> > + <relation type="one" fk-name="UP_User_Group_Type"
> rel-entity-name="
> > UserPrefGroupType">
> > + <key-map field-name="userPrefGroupTypeId"/>
> > + </relation>
> > </entity>
> >
> > <entity entity-name="UserPrefGroupType"
> >
> >
> >
>
Re: svn commit: r1809375 - /ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
Posted by Deepak Dixit <de...@hotwaxsystems.com>.
Hi Aditya,
It would be good if we use upper case for fk-name, as its constraints and
across the application we are using fk-name as upper case.
Thanks & Regards
--
Deepak Dixit
www.hotwaxsystems.com
www.hotwax.co
On Sat, Sep 23, 2017 at 1:54 PM, <jl...@apache.org> wrote:
> Author: jleroux
> Date: Sat Sep 23 08:24:08 2017
> New Revision: 1809375
>
> URL: http://svn.apache.org/viewvc?rev=1809375&view=rev
> Log:
> Implemented: Missing foreign key constraint for fields userLoginId &
> userPrefGroupTypeId in UserPreference entity
>
> UserPreference.userLoginId is related to UserLogin.userLoginId.
> UserPreference.userPrefGroupTypeId is related to
> UserPrefGroupType.userPrefGroupTypeId.
>
> (OFBIZ-9678)
>
>
> Thanks: Aditya
>
> Modified:
> ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
>
> Modified: ofbiz/ofbiz-framework/trunk/framework/common/entitydef/
> entitymodel.xml
> URL: http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/
> framework/common/entitydef/entitymodel.xml?rev=1809375&
> r1=1809374&r2=1809375&view=diff
> ============================================================
> ==================
> --- ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
> (original)
> +++ ofbiz/ofbiz-framework/trunk/framework/common/entitydef/entitymodel.xml
> Sat Sep 23 08:24:08 2017
> @@ -639,6 +639,12 @@ under the License.
> <field name="userPrefDataType" type="id-long"><description>The
> java data type of this preference (empty = java.lang.String)</
> description></field>
> <prim-key field="userLoginId"/>
> <prim-key field="userPrefTypeId"/>
> + <relation type="one" fk-name="UP_User_Login"
> rel-entity-name="UserLogin">
> + <key-map field-name="userLoginId"/>
> + </relation>
> + <relation type="one" fk-name="UP_User_Group_Type" rel-entity-name="
> UserPrefGroupType">
> + <key-map field-name="userPrefGroupTypeId"/>
> + </relation>
> </entity>
>
> <entity entity-name="UserPrefGroupType"
>
>
>