You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by shwetaag <gi...@git.apache.org> on 2015/08/21 14:19:03 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
GitHub user shwetaag opened a pull request:
https://github.com/apache/cloudstack/pull/728
CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 5.9
Check the bug 8756 for more details
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shwetaag/cloudstack attach_iso
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/728.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #728
----
commit bbdb47854df106f6c95b9c8935ffc3717eac3617
Author: shweta agarwal <sh...@citrix.com>
Date: 2015-08-21T12:17:01Z
CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 5.9
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/728
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-134504120
result information :
@desc:Incorrect guest os mapping in vmware for CentOS 5.9 and above ... === TestName: test2_attach_ISO_in_CentOSVM | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 392.003s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/728#discussion_r37962558
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -775,6 +775,15 @@
"ostype": "CentOS 5.6 (64-bit)"
},
+ "CentOS6.3template": {
+ "displaytext": "Centos",
+ "name": "Centos",
+ "passwordenabled": False,
+ "ostype": "CentOS 6.3 (64-bit)",
+ "url": "http://10.147.28.7/templates/centos63.ova",
--- End diff --
Agree, and this should be parameterised IMHO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139582425
Hi @sanju1010 please use git-pr script to merge pull requests. Its in the source code at tools/git/git-pr
Here is a doc on how to use it https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61311655
If you face any issues, please ping me or @remibergsma. Do not do direct commits like above to master. only merge commits should be in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by nitt10prashant <gi...@git.apache.org>.
Github user nitt10prashant commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139530956
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by miguelaferreira <gi...@git.apache.org>.
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139623577
Thanks @karuturi ! :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-133548095
@shwetaag Please add more details on the actual problem (also in Jira) and what you want to achieve by adding this test. Both CentOS 5 and CCP 4.2.1seem very specific (and old) to me. But I might be missing something so let me know :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-134034345
@remibergsma the issue was of incorrect mapping of centos guest os (grater than 5.9 ) in cloud stack .CS was sending wrong info to Vcenter to launch VMs and centos VMs guest os is set to others .
This will cause CentOS( 5.9 or any other greater version) unable to be provided on VMware certain operations like attach and detach iso.
so this test case is about verifying that attach and detach iso is working fine with vmware VMs especially when using centos guest os
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by sanju1010 <gi...@git.apache.org>.
Github user sanju1010 commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-137719672
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by karuturi <gi...@git.apache.org>.
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-139586066
I reverted the directed commit and merged this pr.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-134706537
@shwetaag I have no VMware so cannot run this test. Is there any way to make the test more generic?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/728#discussion_r38500164
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -775,6 +775,15 @@
"ostype": "CentOS 5.6 (64-bit)"
},
+ "CentOS6.3template": {
+ "displaytext": "Centos",
+ "name": "Centos",
+ "passwordenabled": False,
+ "ostype": "CentOS 6.3 (64-bit)",
+ "url": "http://10.147.28.7/templates/centos63.ova",
--- End diff --
@bhaisaab this is a simple centos template for vmware so nothing special about it. for this test to pass in one's environment he should have centos template uploaded in their http server and change the url accordingly .
If you have a place where we can share this file publicly i will be more than happy to upload it there. Not only this file, i will upload lot other files whose urls are a private http server mentioned in test_data.py
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8756:Incorrect guest os mappin...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/728#discussion_r37961562
--- Diff: tools/marvin/marvin/config/test_data.py ---
@@ -775,6 +775,15 @@
"ostype": "CentOS 5.6 (64-bit)"
},
+ "CentOS6.3template": {
+ "displaytext": "Centos",
+ "name": "Centos",
+ "passwordenabled": False,
+ "ostype": "CentOS 6.3 (64-bit)",
+ "url": "http://10.147.28.7/templates/centos63.ova",
--- End diff --
Can you share or host this ova publicly? Will this test fail for this URL/file not available in one's env.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---